Merge pull request #1662 from AntelopeIO/gh_1621

[2.0.0-dev] Remove deprecated functions.

Author: greg7mdp

libraries/chain/abi_serializer.cpp

@@ -74,11 +74,6 @@ namespace eosio::chain {
       set_abi(std::move(abi), yield);
    }
 
-   abi_serializer::abi_serializer( const abi_def& abi, const fc::microseconds& max_serialization_time) {
-      configure_built_in_types();
-      set_abi(abi, create_yield_function(max_serialization_time));
-   }
-
    void abi_serializer::add_specialized_unpack_pack( const string& name,
                                                      std::pair<abi_serializer::unpack_function, abi_serializer::pack_function> unpack_pack ) {
       built_in_types[name] = std::move( unpack_pack );
@@ -192,10 +187,6 @@ namespace eosio::chain {
       validate(ctx);
    }
 
-   void abi_serializer::set_abi(const abi_def& abi, const fc::microseconds& max_serialization_time) {
-      return set_abi(abi, create_yield_function(max_serialization_time));
-   }
-
    bool abi_serializer::is_builtin_type(const std::string_view& type)const {
       return built_in_types.find(type) != built_in_types.end();
    }

libraries/chain/controller.cpp

@@ -5506,38 +5506,13 @@ block_handle controller::head()const {
    return my->chain_head;
 }
 
-uint32_t controller::head_block_num()const {
-   return my->chain_head.block_num();
-}
-block_timestamp_type controller::head_block_timestamp()const {
-   return my->chain_head.block_time();
-}
-time_point controller::head_block_time()const {
-   return my->chain_head.block_time();
-}
-block_id_type controller::head_block_id()const {
-   return my->chain_head.id();
-}
-
-account_name  controller::head_block_producer()const {
-   return my->chain_head.producer();
-}
-
-const block_header& controller::head_block_header()const {
-   return my->chain_head.header();
-}
-
 block_state_legacy_ptr controller::head_block_state_legacy()const {
    // returns null after instant finality activated
    return block_handle_accessor::apply_l<block_state_legacy_ptr>(my->chain_head, [](const auto& head) {
       return head;
    });
 }
 
-const signed_block_ptr& controller::head_block()const {
-   return my->chain_head.block();
-}
-
 std::optional<finality_data_t> controller::head_finality_data() const {
    return my->head_finality_data();
 }
@@ -5546,14 +5521,6 @@ block_handle controller::fork_db_head()const {
    return my->fork_db_head();
 }
 
-uint32_t controller::fork_db_head_block_num()const {
-   return my->fork_db_head_block_num();
-}
-
-block_id_type controller::fork_db_head_block_id()const {
-   return my->fork_db_head_block_id();
-}
-
 block_timestamp_type controller::pending_block_timestamp()const {
    return my->pending_block_timestamp();
 }

libraries/chain/include/eosio/chain/abi_serializer.hpp

@@ -47,11 +47,7 @@ struct abi_serializer {
 
    abi_serializer(){ configure_built_in_types(); }
    abi_serializer( abi_def abi, const yield_function_t& yield );
-   [[deprecated("use the overload with yield_function_t[=create_yield_function(max_serialization_time)]")]]
-   abi_serializer( const abi_def& abi, const fc::microseconds& max_serialization_time );
    void set_abi( abi_def abi, const yield_function_t& yield );
-   [[deprecated("use the overload with yield_function_t[=create_yield_function(max_serialization_time)]")]]
-   void set_abi(const abi_def& abi, const fc::microseconds& max_serialization_time);
 
    /// @return string_view of `t` or internal string type
    std::string_view resolve_type(const std::string_view& t)const;

libraries/chain/include/eosio/chain/controller.hpp

@@ -287,23 +287,12 @@ namespace eosio::chain {
          block_handle         head()const;
          block_handle         fork_db_head()const;
 
-         [[deprecated("Use head().block_num().")]]  uint32_t             head_block_num()const;
-         [[deprecated("Use head().block_time().")]] time_point           head_block_time()const;
-         [[deprecated("Use head().timestamp().")]]  block_timestamp_type head_block_timestamp()const;
-         [[deprecated("Use head().id().")]]         block_id_type        head_block_id()const;
-         [[deprecated("Use head().producer().")]]   account_name         head_block_producer()const;
-         [[deprecated("Use head().header().")]]     const block_header&  head_block_header()const;
-         [[deprecated("Use head().block().")]]      const signed_block_ptr& head_block()const;
-
          // returns nullptr after instant finality enabled
          block_state_legacy_ptr head_block_state_legacy()const;
          // returns finality_data associated with chain head for SHiP when in Savanna,
          // std::nullopt in Legacy
          std::optional<finality_data_t> head_finality_data() const;
 
-         [[deprecated("Use fork_db_head().block_num().")]] uint32_t      fork_db_head_block_num()const;
-         [[deprecated("Use fork_db_head().id().")]]        block_id_type fork_db_head_block_id()const;
-
          time_point                     pending_block_time()const;
          block_timestamp_type           pending_block_timestamp()const;
          account_name                   pending_block_producer()const;