Upgrade TBB

[servantftransperfect]

Hello,

Would it be possible to upgrade tbb ? Current version is causing problem with cmake 4+ (cmake_minimum_version is too low).

It would also be very nice to enable use of provided tbb.

Thanks.

Fabien

[BrunoLevy]

Hello, would you tell me more about your setting and the problem that you encountered / which version of TBB you want to use ?

[servantftransperfect]

I am using cmake 4.2.3.

First of all, i tried to build using

-DBUILD_SHARED_LIBS=ON -DGEOGRAM_LIB_ONLY=ON -DGEOGRAM_WITH_GRAPHICS=OFF

Which give me a
/bin/ld: cannot find -ltbb

because of (i think you should remove this line !)

if(LINUX) # For now here (quick and dirty fix, for using parallel STL)
target_link_libraries(geogram tbb)
endif()

There is no place in the code where it looks for the tbb package except if I activate GEOGRAM_USE_TBB. If i activate this option, i get this error:

-- Third-party: creating target 'TBB::tbb' (OneTBB)
Cloning into 'tbb-src'...
HEAD is now at 8b829acc Update documentation for oneTBB 2021.11.0 (#1268)
CMake Error at /s/apps/users/servantf/packages/geogram/build.1.8.2/build/platform-linux/build-release/geogram-prefix/src/geogram-build/_deps/tbb-src/CMakeLists.txt:15 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

I managed to build geogram by removing the previously cited line, and replacing

#include(cmake/onetbb.cmake)

by

find_package(TBB REQUIRED)

[BrunoLevy]

Hi,

• TBB is used under the hood by the parallel STL library in g++, this is why you need it even when there is no explicit reference to it in the code.
• make sure you compile using the procedure detailed here