Fix several firefox bugs

- Prevent negative availability caching for unreleased executables.
- Prevent additional caching of PublicBrowserStateCache results.
- Fix firefox public cache URL.

Author: GJFR

bughog/subject/web_browser/chromium/state_oracle.py

@@ -37,11 +37,11 @@ def find_commit_id(self, commit_nb: int) -> str:
         assert re.match(r'[a-z0-9]{40}', rev_id)
         return rev_id
 
-    @Cache.cache_in_db('web_browser', 'chromium')
+    # @Cache.cache_in_db('web_browser', 'chromium')
     def find_commit_nb_of_release(self, release_version: int) -> int:
         return PublicBrowserStateCache.get_release_commit_nb('chromium', release_version)
 
-    @Cache.cache_in_db('web_browser', 'chromium')
+    # @Cache.cache_in_db('web_browser', 'chromium')
     def find_commit_id_of_release(self, release_version: int) -> str:
         return PublicBrowserStateCache.get_release_commit_id('chromium', release_version)
 
@@ -50,13 +50,13 @@ def get_most_recent_major_release_version(self) -> int:
 
     # Release state functions
 
-    @Cache.cache_in_db('web_browser', 'chromium')
+    # @Cache.cache_in_db('web_browser', 'chromium')
     def has_public_release_executable(self, major_version: int) -> bool:
         # TODO: check cache at factory
         commit_nb = PublicBrowserStateCache.get_release_commit_nb('chromium', major_version)
         return self.has_public_commit_executable(commit_nb)
 
-    @Cache.cache_in_db('web_browser', 'chromium')
+    # @Cache.cache_in_db('web_browser', 'chromium')
     def get_release_executable_download_urls(self, major_version: int) -> list[str]:
         commit_nb = PublicBrowserStateCache.get_release_commit_nb('chromium', major_version)
         return self.get_commit_executable_download_urls(commit_nb)

bughog/subject/web_browser/firefox/state_oracle.py

@@ -4,19 +4,19 @@
 
 
 class FirefoxStateOracle(StateOracle):
-    @Cache.cache_in_db('web_browser', 'firefox')
+    # @Cache.cache_in_db('web_browser', 'firefox')
     def find_commit_nb(self, commit_id: str) -> int:
         return PublicBrowserStateCache.firefox_get_commit_nb(commit_id)
 
-    @Cache.cache_in_db('web_browser', 'firefox')
+    # @Cache.cache_in_db('web_browser', 'firefox')
     def find_commit_id(self, commit_nb: int) -> str:
         return PublicBrowserStateCache.firefox_get_commit_id(commit_nb)
 
-    @Cache.cache_in_db('web_browser', 'firefox')
+    # @Cache.cache_in_db('web_browser', 'firefox')
     def find_commit_nb_of_release(self, release_version: int) -> int:
         return PublicBrowserStateCache.get_release_commit_nb('firefox', release_version)
 
-    @Cache.cache_in_db('web_browser', 'firefox')
+    # @Cache.cache_in_db('web_browser', 'firefox')
     def find_commit_id_of_release(self, release_version: int) -> str:
         return PublicBrowserStateCache.get_release_commit_id('firefox', release_version)
 
@@ -36,7 +36,9 @@ def get_release_executable_download_urls(self, major_version: int) -> list[str]:
     def get_commit_url(self, commit_nb: int, commit_id: str) -> str:
         return f'https://hg.mozilla.org/releases/mozilla-release/rev/{commit_id}'
 
-    @Cache.cache_in_db('web_browser', 'firefox')
+    # We don't cache this for firefox, since it is implicitly caches by PublicBrowserStateCache.
+    # If we would, negative results for future executables remain stored even after the executable becomes available.
+    # @Cache.cache_in_db('web_browser', 'firefox')
     def has_public_commit_executable(self, commit_nb: int) -> bool:
         return PublicBrowserStateCache.firefox_has_executable_for(commit_nb=commit_nb)
 

bughog/subject/web_browser/state_cache.py

@@ -27,7 +27,7 @@ def safe_request_json_and_update(collection_name: str, transform=lambda x: x):
                 logger.error(f"Could not update commit cache for {collection_name}", exc_info=True)
 
         executor = ThreadPoolExecutor()
-        executor.submit(safe_request_json_and_update, "firefox_executable_availability", transform=lambda x: list(x.values()))
+        executor.submit(safe_request_json_and_update, "firefox_binary_availability", transform=lambda x: list(x.values()))
         executor.submit(safe_request_json_and_update, "firefox_release_base_revs")
         executor.submit(safe_request_json_and_update, "chromium_release_base_revs")
         executor.shutdown(wait=False)