Skip to content

Commit c58989f

Browse files
AndrewBWSricofreak
authored andcommitted
Bug 41588: Normalize spaces in 856$u links
To test: 1 - add 856$u " www.cheese.com" to a record 2 - confirm link does not work from results or details in either staff interface or OPAC 3 - add 856$u "www.cheese.com " to a record 4 - confirm link does not work from results or details in either staff interface or OPAC 7 - apply patch, restart_all 8 - reload pages, confirm both links work in results and details in staff interface and OPAC Optional final step: have some cheese as a treat Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
1 parent b626e4f commit c58989f

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -973,7 +973,7 @@
973973
<xsl:with-param name="indicator1" select="@ind1"/>
974974
<xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
975975
</xsl:call-template>
976-
<xsl:value-of select="marc:subfield[@code='u']"/>
976+
<xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
977977
</xsl:attribute>
978978
<xsl:choose>
979979
<xsl:when test="($Show856uAsImage='Details' or $Show856uAsImage='Both') and (substring($SubqText,1,6)='image/' or $SubqText='img' or $SubqText='bmp' or $SubqText='cod' or $SubqText='gif' or $SubqText='ief' or $SubqText='jpe' or $SubqText='jpeg' or $SubqText='jpg' or $SubqText='jfif' or $SubqText='png' or $SubqText='svg' or $SubqText='tif' or $SubqText='tiff' or $SubqText='ras' or $SubqText='cmx' or $SubqText='ico' or $SubqText='pnm' or $SubqText='pbm' or $SubqText='pgm' or $SubqText='ppm' or $SubqText='rgb' or $SubqText='xbm' or $SubqText='xpm' or $SubqText='xwd')">

koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,7 @@
990990
<xsl:with-param name="indicator1" select="@ind1"/>
991991
<xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
992992
</xsl:call-template>
993-
<xsl:value-of select="marc:subfield[@code='u']"/>
993+
<xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
994994
</xsl:attribute>
995995
<xsl:choose>
996996
<xsl:when test="($Show856uAsImage='Results' or $Show856uAsImage='Both') and (substring($SubqText,1,6)='image/' or $SubqText='img' or $SubqText='bmp' or $SubqText='cod' or $SubqText='gif' or $SubqText='ief' or $SubqText='jpe' or $SubqText='jpeg' or $SubqText='jpg' or $SubqText='jfif' or $SubqText='png' or $SubqText='svg' or $SubqText='tif' or $SubqText='tiff' or $SubqText='ras' or $SubqText='cmx' or $SubqText='ico' or $SubqText='pnm' or $SubqText='pbm' or $SubqText='pgm' or $SubqText='ppm' or $SubqText='rgb' or $SubqText='xbm' or $SubqText='xpm' or $SubqText='xwd')">

koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1087,7 +1087,7 @@
10871087
<xsl:with-param name="indicator1" select="@ind1"/>
10881088
<xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
10891089
</xsl:call-template>
1090-
<xsl:value-of select="marc:subfield[@code='u']"/>
1090+
<xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
10911091
</xsl:attribute>
10921092
</xsl:otherwise>
10931093
</xsl:choose>

koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1209,7 +1209,7 @@
12091209
<xsl:with-param name="indicator1" select="@ind1"/>
12101210
<xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
12111211
</xsl:call-template>
1212-
<xsl:value-of select="marc:subfield[@code='u']"/>
1212+
<xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
12131213
</xsl:attribute>
12141214
</xsl:otherwise>
12151215
</xsl:choose>

0 commit comments

Comments
 (0)