fix InvokeAsync violations

Author: MattParkerDev

src/SharpIDE.Godot/Features/Nuget/NugetPackageDetails.cs

@@ -32,7 +32,7 @@ public override void _Ready()
 		_versionOptionButton = GetNode<OptionButton>("%VersionOptionButton");
 		_nugetSourceOptionButton = GetNode<OptionButton>("%NugetSourceOptionButton");
 		_projectsVBoxContainer = GetNode<VBoxContainer>("%ProjectsVBoxContainer");
-		_nugetSourceOptionButton.ItemSelected += OnNugetSourceSelected;
+		_nugetSourceOptionButton.ItemSelected += index => _ = Task.GodotRun(() => OnNugetSourceSelected(index));
 		_versionOptionButton.ItemSelected += VersionSelected;
 
 		_projectsVBoxContainer.QueueFreeChildren();
@@ -71,8 +71,8 @@ await this.InvokeAsync(() =>
 				_nugetSourceOptionButton.AddItem(packageFromSource.Source.Name);
 			}
 			_nugetSourceOptionButton.Selected = 0;
-			OnNugetSourceSelected(0);
 		});
+		await OnNugetSourceSelected(0);
 	}
 
 	public async Task SetProjects(HashSet<SharpIdeProjectModel> projects)
@@ -112,7 +112,7 @@ await this.InvokeAsync(() =>
 		});
 	}
 
-	private async void OnNugetSourceSelected(long sourceIndex)
+	private async Task OnNugetSourceSelected(long sourceIndex)
 	{
 		var packageFromSource = _package!.PackageFromSources[(int)sourceIndex];
 		var results = await _nugetClientService.GetAllVersionsOfPackageInSource(packageFromSource.PackageSearchMetadata.Identity.Id, packageFromSource.Source);

src/SharpIDE.Godot/Features/Nuget/NugetPanel.cs

@@ -137,17 +137,17 @@ private async Task PopulateSearchResults()
 		return;
 		using var _ = SharpIdeOtel.Source.StartActivity($"{nameof(NugetPanel)}.{nameof(PopulateSearchResults)}");
 		var result = await _nugetClientService.GetTop100Results(_solution!.DirectoryPath);
-		var scenes = result.Select(s =>
+		using var scenes = result.AsValueEnumerable().Select(s =>
 		{
 			var scene = _packageEntryScene.Instantiate<PackageEntry>();
 			scene.PackageResult = s;
 			scene.PackageSelected += OnPackageSelected;
 			return scene;
-		}).ToList();
+		}).ToArrayPool();
 		await this.InvokeAsync(() =>
 		{
 			_availablePackagesItemList.QueueFreeChildren();
-			foreach (var scene in scenes)
+			foreach (var scene in scenes.Span)
 			{
 				_availablePackagesItemList.AddChild(scene);
 			}

src/SharpIDE.Godot/Features/Nuget/PackageEntry.cs

@@ -44,7 +44,7 @@ public override void _Ready()
 		_packageIconTextureRect = GetNode<TextureRect>("%PackageIconTextureRect");
 		_latestVersionLabel.Text = string.Empty;
 		ApplyValues();
-		_button.Pressed += async () => await PackageSelected.Invoke(PackageResult);
+		_button.Pressed += () => _ = Task.GodotRun(() => PackageSelected.Invoke(PackageResult));
 	}
 
 	private void ApplyValues()