reception of bytes is not checked

[eyal-rounds]

according to the spec if in 8 ticks more the one phase shift occurs it's a timing violation. this code does not check it at all, it hops from 2nd tick to the next 2nd tick of each bit.
also when preparing the byte from the byte array doesn't take into account the start bit.

[pavanshah2001]

Hi @eyal-rounds , were you able to get this library working with the bug fix you did? I'm not able to make this work. How did you handle assigning short address?

[eyal-rounds]

not entirely, it did work to some extent, eventually we created in our company another library from scratch that handles RX pin using interrupt handler + timer and TX using just the timer handler set to half bit time, unlike this code that is timed to 1/8 byte time hoping to catch changes. It could very well be that the current code is missing quite some data packets and there for the assigning of short addresses might fail.You CAN make the current code work using a dali click + microcontroller\logic analyzer to see why data is not coming back or misinterpreted  but the logic like saleas is not getting all dali signals properly - from our experience at least and needs a custom plugin to salea to be interpenetrated properly.  IMHO the library architecture is not well suited for bit banging and that's why it doesn't work. On Sunday, April 9, 2023 at 02:09:36 PM GMT+3, pavanshah2001 ***@***.***> wrote: Hi @eyal-rounds , were you able to get this library working with the bug fix you did? I'm not able to make this work. How did you handle assigning short address? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>