From 9956102ff29892a80786ba46ff83f24658b2c918 Mon Sep 17 00:00:00 2001 From: Nicole Aschenbrenner Date: Thu, 23 Apr 2026 03:05:36 -0500 Subject: [PATCH] [smoke-dev] Remove multi-device test Remove xteam-red-min-max-float-multi-device test which depends on -fopenmp-target-multi-device flag. This flag is being removed from ROCm/llvm-project (PR #2277) as part of driver convergence effort. Test purpose was to verify multi-device compilation compatibility with Xteam min/max reduction. With multi-device feature removed, this test becomes redundant. Depends on: ROCm/llvm-project#2277 --- .../Makefile | 19 ------- .../xteam-red-min-max-float-multi-device.c | 49 ------------------- 2 files changed, 68 deletions(-) delete mode 100644 test/smoke-dev/xteam-red-min-max-float-multi-device/Makefile delete mode 100644 test/smoke-dev/xteam-red-min-max-float-multi-device/xteam-red-min-max-float-multi-device.c diff --git a/test/smoke-dev/xteam-red-min-max-float-multi-device/Makefile b/test/smoke-dev/xteam-red-min-max-float-multi-device/Makefile deleted file mode 100644 index d90453c20c..0000000000 --- a/test/smoke-dev/xteam-red-min-max-float-multi-device/Makefile +++ /dev/null @@ -1,19 +0,0 @@ -include ../../Makefile.defs - -TESTNAME = xteam-red-min-max-float-multi-device -TESTSRC_MAIN = xteam-red-min-max-float-multi-device.c -TESTSRC_AUX = -TESTSRC_ALL = $(TESTSRC_MAIN) $(TESTSRC_AUX) -RUNENV += HSA_XNACK=1 OMPX_APU_MAPS=1 LIBOMPTARGET_NUM_MULTI_DEVICES=1 LIBOMPTARGET_KERNEL_TRACE=1 - -RUNCMD = ./$(TESTNAME) 2>&1 | $(FILECHECK) $(TESTSRC_MAIN) - -CFLAGS += -fopenmp-target-multi-device -EXTRA_LDFLAGS += -lm -CLANG = clang -OMP_BIN = $(AOMP)/bin/$(CLANG) -CC = $(OMP_BIN) $(VERBOSE) -#-ccc-print-phases -#"-\#\#\#" - -include ../Makefile.rules diff --git a/test/smoke-dev/xteam-red-min-max-float-multi-device/xteam-red-min-max-float-multi-device.c b/test/smoke-dev/xteam-red-min-max-float-multi-device/xteam-red-min-max-float-multi-device.c deleted file mode 100644 index eea219a04b..0000000000 --- a/test/smoke-dev/xteam-red-min-max-float-multi-device/xteam-red-min-max-float-multi-device.c +++ /dev/null @@ -1,49 +0,0 @@ -/* - * Test multi-device min/max reduction on floats using minf/maxf. - * There are 2 target regions in this program, the first has min/max reduction - * and the second has a sum reduction. The program is compiled with multi-device - * ON. Since multi-device compilation may be incompatible with Xteam min/max, the - * first target region does not use Xteam reduction. The second one, however, does. - */ -#include -#include -#include -#include - -int main() -{ - int N = 1000; - - float a[N]; - - for (int i = 0; i < N; i++) - a[i] = i + 11; - - float max1 = 0; - float min1 = 1000000; - float sum1 = 0; - -#pragma omp target teams distribute parallel for reduction(max : max1) reduction(min : min1) - for (int i = 0; i < N; i = i + 1) - { - max1 = fmaxf(max1, a[i]); - min1 = fminf(min1, a[i]); - } - - #pragma omp target teams distribute parallel for reduction(+ : sum1) - for (int i = 0; i < N; i = i + 1) - sum1 += a[i]; - - printf("max1 = %f min1 = %f sum1 = %f\n", max1, min1, sum1); - int rc = (max1 != 1010) || (min1 != 11) || (sum1 != 510500); - - if (!rc) - printf("Success\n"); - else - printf("Failed\n"); - - return rc; -} - -/// CHECK: DEVID:[[S:[ ]*]][[DEVID:[0-9]+]] SGN:2 -/// CHECK: DEVID:[[S:[ ]*]][[DEVID:[0-9]+]] SGN:8 \ No newline at end of file