Better theme experience

[1208nn]

Turn theme switcher into a button supporting following browser theme. On click it changes (dark/light/system).

[Jixabon]

Hey @1208nn, I like this idea! There is a plan to rework the css and theming soon. As of right now there are separate stylesheets that are swapped out to apply a theme. I can see this being a potential sticking point while implementing this request. As of right now to do that you'd likely need to implement the functionality via JS. I can be sure to incorporate this idea when going through the CSS and Themes!

[1208nn]

I think the light part and the dark part should be one theme and currently, we have light, dark and hackernews.

I'm working on it at #2088. I have explained my basic idea about how each theme react with color mode in it. I found codes now have no very good support for themes, lots of codes are written as hardcoded values.

I'm not very familiar with php, and I realized that this is a hard work. I most likely won’t be able to finish it on my own😭.

[Jixabon]

Before you get too far, I plan to restructure the stylesheets completely likely in the next few days. I can pull some of the changes you've done already over and we could collaborate on that as a starting point to improve things. Then you can help where comfortable.

Another comment is try to keep your PRs specific and handling the one thing it's meant to address. In this case adding support for the browser's preferred theme mode. I think with the current code this is more difficult than it should be. It will likely be much easier after the restructure. Take a look at other PRs before hand to see if they may be addressing things already.

[1208nn]

Emm... My main purpose for the PR is to support follow browser preferred color.

That's why to change the check box: It only have checked/unchecked so that cannot be the UI for light/dark/system.

The theme system now has default(light)/Lights Out(dark)/Hackernews. This won't be fit for the new feature, so I have to change it and clarify & separate theme and theme mode.

[1208nn]

I am very confused that .gitignore ignores mo files, but they are in the repo.

Should I use composer test? composer.json exits but the vendor folder and composer.lock is not in the gitignore.

[billz]

I am very confused that .gitignore ignores mo files, but they are in the repo

The .mo files are binary artifacts compiled from their .po source files, making tracking redundant