It is very good to provide source of diagnostics as part of LSP diagnostics so that other sources for problems are easily identified in the IDE/editor UI.
Without the source of diagnostics the problems/issues are not easily traceable to the LSP server.
An example of impact is rendering like below

pyang is the source which clearly identifies the source.
It is very good to provide source of diagnostics as part of LSP diagnostics so that other sources for problems are easily identified in the IDE/editor UI.
Without the source of diagnostics the problems/issues are not easily traceable to the LSP server.
An example of impact is rendering like below

pyangis the source which clearly identifies the source.