Skip to content

Commit cef5b6c

Browse files
authored
fix: Do not retry if autoapproved (#98)
closes: #97
1 parent 80f5a37 commit cef5b6c

4 files changed

Lines changed: 1045 additions & 2506 deletions

File tree

cypress/integration/regression.spec.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,12 @@ describe("Regression suite", () => {
7777
status: TestStatus.new,
7878
})
7979
).to.be.true;
80+
expect(
81+
utils.shouldStopRetry({
82+
...testRunResponce,
83+
status: TestStatus.autoApproved,
84+
})
85+
).to.be.true;
8086
});
8187
});
8288
});

lib/utils.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ export const checkResult = (result: TestRunResponse) =>
3030
cy.task("VRT_PROCESS_ERROR_RESULT", result, { log: false });
3131

3232
export const shouldStopRetry = (result: TestRunResponse) =>
33-
result?.status === TestStatus.ok ||
34-
// no need to retry if no baseline
35-
result?.status === TestStatus.new;
33+
result?.status !== TestStatus.unresolved;
3634

3735
export const trackImage = (
3836
subject: any,
@@ -61,7 +59,11 @@ export const trackImage = (
6159
name,
6260
imageBase64,
6361
browser: Cypress.browser.name,
64-
viewport: options?.viewport ?? `${Cypress.config("viewportWidth") * pixelRatio}x${Cypress.config("viewportHeight") * pixelRatio}`,
62+
viewport:
63+
options?.viewport ??
64+
`${Cypress.config("viewportWidth") * pixelRatio}x${
65+
Cypress.config("viewportHeight") * pixelRatio
66+
}`,
6567
pixelRatio,
6668
os: options?.os,
6769
device: options?.device,

0 commit comments

Comments
 (0)