fix: convert display-width offsets to char indices when expanding paste extmarks#28778
Closed
xodmd45-ctrl wants to merge 1 commit into
Closed
fix: convert display-width offsets to char indices when expanding paste extmarks#28778xodmd45-ctrl wants to merge 1 commit into
xodmd45-ctrl wants to merge 1 commit into
Conversation
…te extmarks When submitting a prompt with pasted content, the code expanded extmarks using extmark.start/end directly as slice() arguments. However, extmark positions are display-width offsets (visual columns), not JS string indices. For CJK characters (visual width 2), this caused slice() to cut at wrong positions, resulting in [Pasted text appearing in the submitted message instead of the actual pasted content. Add visualOffsetToCharIndex() to correctly convert display-width offsets to character indices before slicing the input text.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When submitting a prompt with pasted content after typing CJK characters (Korean, Chinese, Japanese), the submitted message shows literal [Pasted\ text instead of the actual pasted content.
Root Cause
In \submitInner(), the code expands pasted text from extmarks using:
\\ s
const before = inputText.slice(0, extmark.start)
const after = inputText.slice(extmark.end)
\\
However, extmark \start/\end\ are display-width offsets (visual columns), not JS string indices. \slice()\ expects character indices. For CJK characters (visual width 2, string length 1), these diverge, causing \slice()\ to cut at wrong positions.
Fix
Add \�isualOffsetToCharIndex()\ that walks the string accumulating visual width until reaching the target offset, then returns the corresponding character index. Use it to convert extmark positions before slicing.
Related