Skip to content

feat(AQE): empty join handling#1723

Open
sandugood wants to merge 2 commits into
apache:mainfrom
sandugood:feat/empty-join-elimination
Open

feat(AQE): empty join handling#1723
sandugood wants to merge 2 commits into
apache:mainfrom
sandugood:feat/empty-join-elimination

Conversation

@sandugood
Copy link
Copy Markdown
Contributor

@sandugood sandugood commented May 18, 2026

Which issue does this PR close?

Handles #1359, particularly this part:

verify if we can reuse instead of creating our own rule for eliminating joins

Rationale for this change

Handling cases of different physical types of joins and adding branching for different logical parts (i.e Left or LeftAnti) without adding separate AQE rule - adding logic straight into the PropagateEmptyExecRule

What changes are included in this PR?

  1. Added JoinInfo struct to contain information about the join (both left and right part)
  2. Added as_join function, which can be extended in the future to add support for other physical joins. Right now it handles both SortMerge and HashJoin
  3. Reused is_guaranteed_empty from the Spice-AI implementation of eliminating empty joins.

Are there any user-facing changes?

No

Were this changes tested?

Yes, tests were included in both propagate_empty.rs and join_info.rs

@sandugood sandugood changed the title feat(AQE): added empty join handling feat(AQE): empty join handling May 20, 2026
@milenkovicm
Copy link
Copy Markdown
Contributor

thanks @sandugood will have a look soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants