Skip to content

MINOR: Reduce close delay in testFailureToFenceEpoch #22347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiayaoS wants to merge 1 commit into
base: trunk
Choose a base branch
from
+3 −1
Open

MINOR: Reduce close delay in testFailureToFenceEpoch #22347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...age/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsTestHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,9 @@ public static void testFailureToFenceEpoch(
long producerId;
int initialProducerEpoch;

try (var producer1 = createTransactionalProducer(clusterInstance, "transactional-producer")) {
Copy link
Copy Markdown
Contributor

@muralibasani muralibasani May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about producer1.close(duration 5 secs) in finally ? This will force a hard close after the time out, instead of waiting for pending reqs.

Copy link
Copy Markdown
Contributor Author

@JiayaoS JiayaoS May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about producer1.close(duration 5 secs) in finally ? This will force a hard close after the time out, instead of waiting for pending reqs.

Thanks, that’s a fair point. I considered close(Duration.ofSeconds(5)) as well, but it changes the cleanup behavior to force-close after the timeout. The current approach keeps the try-with-resources close graceful, while bounding the pending requests with a shorter request timeout. Maybe we should decide which behavior is more appropriate for this test.

// Use a shorter request timeout to bound the graceful close delay when the fencing probe leaves producer1 in an empty transaction.
try (var producer1 = createTransactionalProducer(
clusterInstance, "transactional-producer", 60000, 60000, 120000, 1000)) {
producer1.initTransactions();

producer1.beginTransaction();
Expand Down
Loading