From ecec931c5a9ed4dc262b87e08eea80871a63319a Mon Sep 17 00:00:00 2001 From: lupingblaine Date: Thu, 14 May 2026 00:05:53 -0700 Subject: [PATCH] fix: disable MSSQL encryption by default --- .../main/java/com/external/plugins/MssqlPlugin.java | 10 ++++------ .../mssqlPlugin/src/main/resources/form.json | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java b/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java index c546fa03c856..68fc674f712f 100644 --- a/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java +++ b/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java @@ -643,17 +643,15 @@ private static HikariDataSource createConnectionPool( private static void addSslOptionsToUrlBuilder( DatasourceConfiguration datasourceConfiguration, StringBuilder urlBuilder) throws AppsmithPluginException { /* - * - Ideally, it is never expected to be null because the SSL dropdown is set to a initial value. + * - When SSL configuration is absent, default to disabling encryption. */ if (datasourceConfiguration.getConnection() == null || datasourceConfiguration.getConnection().getSsl() == null || datasourceConfiguration.getConnection().getSsl().getAuthType() == null) { - throw new AppsmithPluginException( - AppsmithPluginError.PLUGIN_ERROR, - "Appsmith server has failed to fetch SSL configuration from datasource configuration form. " - + "Please reach out to Appsmith customer support to resolve this."); + urlBuilder.append("encrypt=false;"); + return; } - + /* * - By default, the driver configures SSL in the no verify mode. */ diff --git a/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json b/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json index 7731ac9421aa..9cacb47d1b7b 100644 --- a/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json +++ b/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json @@ -82,7 +82,7 @@ "label": "SSL mode", "configProperty": "datasourceConfiguration.connection.ssl.authType", "controlType": "DROP_DOWN", - "initialValue": "NO_VERIFY", + "initialValue": "DISABLE", "options": [ { "label": "Disable",