chore(docker): remove unused supervisord admin port#41837
Conversation
The supervisord inet HTTP server on port 9001 is not used by anything internally — supervisorctl (Java backend self-restart, RTS, healthcheck, auto_heal) goes through the Unix socket. The admin port is dead config we don't need. Removed: - [inet_http_server] block in supervisord.conf - APPSMITH_SUPERVISOR_USER / _PASSWORD generation in entrypoint.sh - SUPERVISOR_PASSWORD positional arg in docker.env.sh template (shifts REDIS_PASSWORD from \$6 to \$5) - APPSMITH_SUPERVISOR_PASSWORD entry in app.json (Heroku) - /supervisor route in caddy-reconfigure.mjs APPSMITH_SUPERVISOR_PASSWORD set in customer env files will be ignored; the /supervisor URL will 404.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
WalkthroughThis PR removes supervisor password authentication from the Appsmith deployment configuration and updates internal reverse proxy routing. The changes disable the TCP supervisor HTTP interface, strip supervisor credentials from configuration templates and environment generation, and redirect ChangesSupervisor Authentication and Routing Reconfiguration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/26256565614. |
|
Deploy-Preview-URL: https://ce-41837.dp.appsmith.com |
Summary
The supervisord inet HTTP server on port 9001 is not used by anything internally — supervisorctl (Java backend self-restart, RTS, healthcheck, auto_heal) goes through the Unix socket. The admin port is dead config we don't need.
Removed
[inet_http_server]block insupervisord.confAPPSMITH_SUPERVISOR_USER/_PASSWORDgeneration inentrypoint.shSUPERVISOR_PASSWORDpositional arg indocker.env.shtemplate (shiftsREDIS_PASSWORDfrom$6to$5)APPSMITH_SUPERVISOR_PASSWORDentry inapp.json(Heroku)/supervisorroute incaddy-reconfigure.mjsCompatibility
APPSMITH_SUPERVISOR_PASSWORDset in customer env files will be ignored; the/supervisorURL will 404. Docs page covering it will be updated separately.Test plan
supervisorctl statusstill works inside the container (Unix socket)EnvManagerCEImplflow)Summary by CodeRabbit