Skip to content

Add BitMap component (#10110) #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msynk wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add BitMap component (#10110) #12360

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1c01bc3
add BitMap component #10110
msynk May 18, 2026
3f0880d
resolve review comments
msynk May 18, 2026
478dcbf
resolve review comments II
msynk May 18, 2026
3454a53
resolve review comments II
msynk May 19, 2026
7931795
resolve review comments III
msynk May 20, 2026
ff02e84
resolve review comments V
msynk May 20, 2026
b79069b
resolve review comments VI
msynk May 23, 2026
bf9d3b1
resolve review comments VII
msynk May 24, 2026
3e5b401
resolve review comments VIII
msynk May 24, 2026
dc14dbb
resolve review comments IX
msynk May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,12 @@ ModelManifest.xml
# Rider
.idea

#kiro
.kiro

#cursor
.cursor

profile.arm.json

# bit
Expand Down
17 changes: 17 additions & 0 deletions src/BlazorUI/Bit.BlazorUI.Extras/Components/Map/BitMap.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
@namespace Bit.BlazorUI
@inherits BitComponentBase
@typeparam TMapProvider where TMapProvider : class, IBitMapProvider, new()

<div @ref="RootElement"
@attributes="HtmlAttributes"
id="@_Id"
style="@StyleBuilder.Value"
class="@ClassBuilder.Value"
dir="@Dir?.ToString().ToLower()">
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use culture-invariant casing for dir serialization.

Line 10 should avoid culture-sensitive lowercasing to prevent locale-specific output drift in attribute values.

🔧 Proposed fix 
-     dir="`@Dir`?.ToString().ToLower()">
+     dir="`@Dir`?.ToString().ToLowerInvariant()">
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/BlazorUI/Bit.BlazorUI.Extras/Components/Map/BitMap.razor` at line 10, The
dir attribute is being serialized with Dir?.ToString().ToLower(), which is
culture-sensitive; change the serialization to use culture-invariant casing
instead (e.g., call ToLowerInvariant() or use
ToString(CultureInfo.InvariantCulture) plus ToLowerInvariant) for the dir
attribute in BitMap.razor so output does not vary by locale; update the
expression that renders dir (the Dir?.ToString().ToLower() call) to use
invariant casing methods.

<div @ref="_mapElement"
class="bit-map-canvas"
tabindex="0"
role="application"
Comment thread
msynk marked this conversation as resolved.
Outdated
aria-label="@AriaLabel"></div>
Comment thread
msynk marked this conversation as resolved.
Outdated
@ChildContent
</div>
Loading
Loading