Unable to pass additional options to Roda session plugin

[jaredcwhite]

When using init :ssr, sessions: true which loads Roda's session plugin, there's no way to provide additional options to that plugin. I would have to use sessions: false and manually set up the Roda plugin as a workaround.

We should add something akin to init :ssr, sessions: true, session_options: { ... } or possibly allow sessions keyword argument to accept an options hash directly in addition to a boolean.

[fpsvogel]

If this line were changed to:

app.plugin :sessions, secret: secret_key, **opts.except(:sessions)

Would that then allow something like init :ssr, sessions: true, key: "my_app.session" (:key being an option of the sessions plugin)? Also, is there an existing test file where a test case for this could be added? I checked test_ssr.rb but I'm not sure that's the right place for testing plugin initialization.

[jaredcwhite]

@fpsvogel yeah, that seems right to me. I'm not sure if we have a setup for testing multiple varities of plugin initialization, but we are testing with sessions set to true so we could add some more setup there for coverage:

https://github.com/bridgetownrb/bridgetown/blob/main/bridgetown-core/test/ssr/config/local_ssr_init.rb

[fpsvogel]

@jaredcwhite Thanks for the pointer. In my PR I ended up going with your latter suggestion in the issue description:

allow sessions keyword argument to accept an options hash directly in addition to a boolean.