Use zombie-reaper

Author: choval

composer.json

@@ -22,7 +22,8 @@
         "react/promise-stream": "^1.3",
         "react/child-process": "^0.6",
         "react/promise": "^2.8|^2.9",
-        "react/event-loop": "^1.2|^1.3"
+        "react/event-loop": "^1.2|^1.3",
+        "choval/zombie-reaper": "^1.0"
     },
     "suggest": {
         "ext-pcntl": "Required to create childs to async blocking code",

composer.lock

@@ -305,8 +305,8 @@ protected static function waitProcessExits(int $pid, ?LoopInterface $loop = null
         }
         $defer = new Deferred();
         $timer = $loop->addPeriodicTimer(0.001, function () use ($pid, $defer) {
-            $r = pcntl_waitpid($pid, $status, \WNOHANG);
-            if (!$r) {
+            $r = zombie_reap($pid);
+            if ($r >= 0) {
                 $defer->resolve($r);
             }
         });
@@ -333,10 +333,8 @@ protected static function killProcess(int $pid, int $signal=15, ?LoopInterface $
         foreach ($pids as $pid) {
             $pid = intval($pid);
             if ($pid) {
-                posix_kill($pid, $signal);
-                if ($loop) {
-                    $promises[] = static::waitProcessExits($pid, $loop);
-                }
+                $promises[$pid] = static::waitProcessExits($pid, $loop);
+                zombie_kill($pid);
             }
         }
         if ($loop) {
@@ -432,6 +430,10 @@ public static function executeWithLoop(LoopInterface $loop, string $cmd, float $
                 foreach ($proc->pipes as $pipe) {
                     $pipe->close();
                 }
+                $pid = $proc->getPid();
+                if ($pid) {
+                    static::killProcess($pid, 15, $loop);
+                }
                 if ($err) {
                     return $defer->reject($err);
                 }
@@ -442,10 +444,6 @@ public static function executeWithLoop(LoopInterface $loop, string $cmd, float $
                     return $defer->reject(new Exception('Process exited with code: ' . $exitCode . "\n$buffer", $exitCode, $trace));
                 }
                 $defer->resolve($buffer);
-                $pid = $proc->getPid();
-                if ($pid) {
-                    static::killProcess($pid, 15, $loop);
-                }
             });
         });
         return $defer->promise();
@@ -599,7 +597,7 @@ public static function asyncWithLoop(LoopInterface $loop, $fn, array $args = [])
         $pid = false;
         $id = bin2hex(random_bytes(16));
         $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 3);
-        $defer = new Deferred(function () use (&$pid, $loop) {
+        $defer = new Deferred(function () use ($id, &$pid, $loop) {
             static::removeFork($id);
             if ($pid) {
                 static::killProcess($pid, 9, $loop);