Skip to content

Only poll ApplicationOverQuic wait_for_data after handshake is ready or we're in early data #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxF12 wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

Only poll ApplicationOverQuic wait_for_data after handshake is ready or we're in early data #2480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b386605
Only poll ApplicationOverQuic wait_for_data after handshake is ready
MaxF12 May 15, 2026
46db266
Fixed comment redundancy
MaxF12 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tokio-quiche/src/quic/io/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,9 @@ where
async fn wait_for_data_or_handshake<A: ApplicationOverQuic>(
&mut self, qconn: &mut QuicheConnection, quic_application: &mut A,
) -> QuicResult<WaitForDataOrHandshakeDirective> {
if quic_application.should_act() {
let connection_ready = qconn.is_established() || qconn.is_in_early_data();

if connection_ready && quic_application.should_act() {
Copy link
Copy Markdown
Contributor

@antoniovicente antoniovicente May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes some sense to me. What tests could we add for this case to ensure we don't regress?

// Poll the application to make progress.
//
// Once the connection has been established (i.e. the handshake is
Expand Down