You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
KSQL-14849: temporarily swap to internal SDK ksql/v0.5.0 + wire real Update
For non-prod end-to-end validation of the self-serve CSU PATCH endpoint.
See the doc comment on Client.UpdateKsqlCluster for the temporary-nature
context and the unswap procedure that runs before merging this PR.
Three categories of changes:
1. Import path swap (6 files):
github.com/confluentinc/ccloud-sdk-go-v2/ksql/v2 →
github.com/confluentinc/ccloud-sdk-go-v2-internal/ksql/v2
go.mod bumped to ccloud-sdk-go-v2-internal/ksql v0.5.0 (the tag cut
today from ccloud-sdk-go-v2-internal #820, generated from cc-api
PR #2507's branch). The public ccloud-sdk-go-v2/ksql line is replaced,
not added alongside — keeping a single SDK dep avoids type-collision
in shared paths like Client.
2. ObjectReference type renames. The internal SDK's generator emits more
granular reference types per field (cc-api spec captures the
distinction); the public v0.2.0 SDK used a single ObjectReference
for everything. Three mechanical swaps in pkg/ccloudv2/ksql.go and
test/test-server/ksql_handlers.go:
- Spec.KafkaCluster: ObjectReference → EnvScopedObjectReference
- Spec.CredentialIdentity: ObjectReference → TypedGlobalObjectReference
- Spec.Environment: ObjectReference → GlobalObjectReference
plus NewObjectReference("sa-...", "", "") → NewTypedGlobalObjectReference(...).
3. Real PATCH call. Client.UpdateKsqlCluster now constructs
KsqldbcmV2ClusterUpdate{Spec: {Environment, Csu}} and calls
ClustersKsqldbcmV2Api.UpdateKsqldbcmV2Cluster(...).Execute() —
no SDK Environment(...) query-param builder on PATCH, env lives
in spec.environment.id in the body (matches cc-control-plane-ksql
codec change in PR #335 / v0.224.0 — the server reads env from
spec.environment.id with a query-param fallback for back-compat).
Build, vet, and ksql unit tests all clean.
Before merging this PR (post cc-api #2507 merge + public SDK release):
- Swap import path back: internal/ksql → public ksql
- Bump go.mod to the new public ccloud-sdk-go-v2/ksql tag (which will
have the same Environment/typed-reference shape because it's
generated from the same minispec)
- Drop Hidden: true on the cobra command in command_cluster_update.go
- Un-draft and final review
0 commit comments