Skip to content

feat(ui): make dropdown positioning responsive #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
delucis wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(ui): make dropdown positioning responsive #7828

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79db50d
feat(ui): make dropdown positioning responsive
delucis May 23, 2026
9ba1e43
fix: handle `ResizeObserver` being undefined in test environment
delucis May 23, 2026
056464e
test: update snapshots
delucis May 23, 2026
3045fa1
style: use named import for `useState()` hook
delucis May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
176 changes: 104 additions & 72 deletions ...s/decap-cms-core/src/components/Editor/__tests__/__snapshots__/EditorToolbar.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ exports[`EditorToolbar should render normal save button 1`] = `
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -127,6 +128,7 @@ exports[`EditorToolbar should render normal save button 1`] = `
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -245,15 +247,17 @@ exports[`EditorToolbar should render normal save button 1`] = `
<div
class="emotion-14 emotion-15 emotion-16"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-17 emotion-18"
role="button"
tabindex="0"
>
editor.editorToolbar.publish
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-17 emotion-18"
role="button"
tabindex="0"
>
editor.editorToolbar.publish
</span>
</div>
</div>
</div>
<div>
Expand Down Expand Up @@ -383,6 +387,7 @@ exports[`EditorToolbar should render normal save button 2`] = `
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -404,6 +409,7 @@ exports[`EditorToolbar should render normal save button 2`] = `
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -522,15 +528,17 @@ exports[`EditorToolbar should render normal save button 2`] = `
<div
class="emotion-14 emotion-15 emotion-16"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-17 emotion-18"
role="button"
tabindex="0"
>
editor.editorToolbar.publish
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-17 emotion-18"
role="button"
tabindex="0"
>
editor.editorToolbar.publish
</span>
</div>
</div>
</div>
<div>
Expand Down Expand Up @@ -927,6 +935,7 @@ exports[`EditorToolbar should render with status=draft,useOpenAuthoring=false 1`
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -948,6 +957,7 @@ exports[`EditorToolbar should render with status=draft,useOpenAuthoring=false 1`
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -1072,15 +1082,17 @@ exports[`EditorToolbar should render with status=draft,useOpenAuthoring=false 1`
<div
class="emotion-16 emotion-17 emotion-18"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
</div>
</div>
<button
class="emotion-21 emotion-22"
Expand Down Expand Up @@ -1238,6 +1250,7 @@ exports[`EditorToolbar should render with status=draft,useOpenAuthoring=true 1`]
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -1259,6 +1272,7 @@ exports[`EditorToolbar should render with status=draft,useOpenAuthoring=true 1`]
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -1417,15 +1431,17 @@ exports[`EditorToolbar should render with status=draft,useOpenAuthoring=true 1`]
<div
class="emotion-16 emotion-17 emotion-18"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
</div>
</div>
<div
class="emotion-21 emotion-22"
Expand Down Expand Up @@ -1610,6 +1626,7 @@ exports[`EditorToolbar should render with status=pending_publish,useOpenAuthorin
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -1631,6 +1648,7 @@ exports[`EditorToolbar should render with status=pending_publish,useOpenAuthorin
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -1755,15 +1773,17 @@ exports[`EditorToolbar should render with status=pending_publish,useOpenAuthorin
<div
class="emotion-16 emotion-17 emotion-18"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
</div>
</div>
<button
class="emotion-21 emotion-22"
Expand Down Expand Up @@ -1921,6 +1941,7 @@ exports[`EditorToolbar should render with status=pending_publish,useOpenAuthorin
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -1942,6 +1963,7 @@ exports[`EditorToolbar should render with status=pending_publish,useOpenAuthorin
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -2082,15 +2104,17 @@ exports[`EditorToolbar should render with status=pending_publish,useOpenAuthorin
<div
class="emotion-16 emotion-17 emotion-18"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
</div>
</div>
<div
class="emotion-21 emotion-22"
Expand Down Expand Up @@ -2270,6 +2294,7 @@ exports[`EditorToolbar should render with status=pending_review,useOpenAuthoring
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -2291,6 +2316,7 @@ exports[`EditorToolbar should render with status=pending_review,useOpenAuthoring
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -2415,15 +2441,17 @@ exports[`EditorToolbar should render with status=pending_review,useOpenAuthoring
<div
class="emotion-16 emotion-17 emotion-18"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
</div>
</div>
<button
class="emotion-21 emotion-22"
Expand Down Expand Up @@ -2581,6 +2609,7 @@ exports[`EditorToolbar should render with status=pending_review,useOpenAuthoring
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
touch-action: manipulation;
margin: 0 10px;
}

Expand All @@ -2602,6 +2631,7 @@ exports[`EditorToolbar should render with status=pending_review,useOpenAuthoring
padding-left: 20px;
padding-right: 40px;
position: relative;
white-space: nowrap;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
Expand Down Expand Up @@ -2760,15 +2790,17 @@ exports[`EditorToolbar should render with status=pending_review,useOpenAuthoring
<div
class="emotion-16 emotion-17 emotion-18"
>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
<div>
<span
aria-expanded="false"
aria-haspopup="true"
class="emotion-19 emotion-20"
role="button"
tabindex="0"
>
editor.editorToolbar.status
</span>
</div>
</div>
<div
class="emotion-21 emotion-22"
Expand Down
Loading
Loading