fix(docs): remove nightly doc_cfg feature so docs.rs builds on stable

`#[doc(cfg(...))]` and `#![feature(doc_cfg)]` are nightly-only, so
docs.rs (stable Rust) was crashing on the docs build and rendering an
empty page. The `rustdoc-args = ["--cfg", "docsrs", ...]` line in
Cargo.toml made things worse by injecting `--cfg docsrs`, which
activated the nightly feature gate.

Drop the nightly feature gate, the explicit `--cfg docsrs` injection
(docs.rs sets it itself), and the `#[cfg_attr(docsrs, doc(cfg(...)))]`
annotations. Feature-gated modules and methods retain their
`#[cfg(feature = "...")]` compilation gates; only the per-item
"Available on feature X" badge is lost, which docs.rs surfaces via
its sidebar Feature flags panel anyway.

Verified with `RUSTDOCFLAGS="--cfg docsrs -D warnings" cargo doc
--all-features` (clean) plus the full build/test/clippy/publish-dry-run
gate.

Author: dibakarsutradhar

Cargo.toml

@@ -55,5 +55,4 @@ serde_json = "1"
 proptest = "1"
 
 [package.metadata.docs.rs]
-all-features = true
-rustdoc-args = ["--cfg", "docsrs", "-D", "warnings"]
+all-features = true

src/client.rs

@@ -76,31 +76,27 @@ impl Bkash {
 
     /// Access the Tokenized Checkout product accessor.
     #[cfg(feature = "tokenized-checkout")]
-    #[cfg_attr(docsrs, doc(cfg(feature = "tokenized-checkout")))]
     #[must_use]
     pub fn tokenized(&self) -> crate::tokenized::TokenizedCheckoutClient<'_> {
         crate::tokenized::TokenizedCheckoutClient::new(self)
     }
 
     /// Access the URL-based Checkout product accessor.
     #[cfg(feature = "checkout")]
-    #[cfg_attr(docsrs, doc(cfg(feature = "checkout")))]
     #[must_use]
     pub fn checkout(&self) -> crate::checkout::CheckoutClient<'_> {
         crate::checkout::CheckoutClient::new(self)
     }
 
     /// Access the Auth & Capture product accessor.
     #[cfg(feature = "auth-capture")]
-    #[cfg_attr(docsrs, doc(cfg(feature = "auth-capture")))]
     #[must_use]
     pub fn auth_capture(&self) -> crate::auth_capture::AuthCaptureClient<'_> {
         crate::auth_capture::AuthCaptureClient::new(self)
     }
 
     /// Access the Subscriptions product accessor.
     #[cfg(feature = "subscriptions")]
-    #[cfg_attr(docsrs, doc(cfg(feature = "subscriptions")))]
     #[must_use]
     pub fn subscriptions(&self) -> crate::subscriptions::SubscriptionsClient<'_> {
         crate::subscriptions::SubscriptionsClient::new(self)

src/lib.rs

@@ -36,29 +36,23 @@
 
 #![deny(missing_docs)]
 #![warn(rust_2018_idioms)]
-#![cfg_attr(docsrs, feature(doc_cfg))]
 
 #[cfg(feature = "auth-capture")]
-#[cfg_attr(docsrs, doc(cfg(feature = "auth-capture")))]
 pub mod auth_capture;
 #[cfg(feature = "checkout")]
-#[cfg_attr(docsrs, doc(cfg(feature = "checkout")))]
 pub mod checkout;
 pub mod client;
 pub mod config;
 pub mod error;
 pub mod models;
 pub mod prelude;
 #[cfg(feature = "subscriptions")]
-#[cfg_attr(docsrs, doc(cfg(feature = "subscriptions")))]
 pub mod subscriptions;
 pub mod token;
 #[cfg(feature = "tokenized-checkout")]
-#[cfg_attr(docsrs, doc(cfg(feature = "tokenized-checkout")))]
 pub mod tokenized;
 pub mod transport;
 #[cfg(feature = "webhooks")]
-#[cfg_attr(docsrs, doc(cfg(feature = "webhooks")))]
 pub mod webhooks;
 
 pub use crate::client::Bkash;