Skip to content

[BUG] Windows: Custom exec keybindings pass malformed arguments to Neovim in v4.25.0 #928

Description

@daniel-leinweber

Describe the bug

After upgrading gh-dash from v4.24.1 to v4.25.0, custom exec keybindings that launch Neovim no longer work on Windows.

The same configuration has been working in older versions. After the upgrade, gh-dash appears to pass an invalid path to Neovim. Neovim reports:

E303: Unable to open swap file for "C:\DEV\FruVaDEV"", recovery impossible

Notice the unexpected trailing double quote in the path.

Downgrading back to v4.24.1 immediately resolves the issue without any configuration changes.


To Reproduce

  1. Install gh-dash v4.25.0 on Windows.

  2. Configure a custom exec keybinding, for example:

    keybindings:
      prs:
        - key: e
          name: edit in nvim
          action: exec
          command: nvim -c ":cd {{.RepoPath}}" +":silent Octo pr edit {{.PrNumber}}"
  3. Configure a valid repoPaths mapping.

  4. Open any pull request or issue in gh dash.

  5. Press the configured key (e).


Expected behavior

Neovim should start, change to the repository directory, and execute the configured command.

This works correctly with gh-dash v4.24.1.


Screenshots

Neovim displays:

E303: Unable to open swap file for "C:\DEV\FruVaDEV"", recovery impossible

The error disappears after downgrading to v4.24.1.


Desktop (please complete the following information):

  • OS: Windows 11
  • Terminal Emulator: Windows Terminal
  • Using tmux? No

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions