Skip to content

Commit 38606d9

Browse files
authored
fix(ci): run npsim with --random.enableEventSeed (#79)
### Briefly, what does this PR introduce? Please link to any relevant presentations or discussions. This PR adds `--random.enableEventSeed` to the npsim CI tests to ensure we end up simulating the same events even when the internal event random number consumption changes. Mostly aspirational until we pick up AIDASoft/DD4hep#1617 (at least for gun)... ### What is the urgency of this PR? - [ ] High (please describe reason below) - [x] Medium - [ ] Low ### What kind of change does this PR introduce? - [x] Bug fix (issue: ensure events are reproducible) - [ ] New feature (issue #__) - [ ] Optimization (issue #__) - [ ] Updated documentation - [ ] other: __ ### Please check if any of the following apply - [ ] This PR introduces breaking changes. Please describe changes users need to make below. - [ ] This PR changes default behavior. Please describe changes below. - [ ] AI was used in preparing this PR. Please describe usage below.
1 parent f622f73 commit 38606d9

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/linux-eic-shell.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ jobs:
104104
export LD_LIBRARY_PATH=$PWD/install/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
105105
npsim --compactFile ${DETECTOR_PATH}/${{ matrix.detector_config }}.xml -G \
106106
--random.seed 1 \
107+
--random.enableEventSeed \
107108
--gun.particle "${{ matrix.particle }}-" \
108109
--gun.momentumMin "1*GeV" \
109110
--gun.momentumMax "20*GeV" \
@@ -182,6 +183,7 @@ jobs:
182183
-N 100 \
183184
--inputFiles ${url} \
184185
--random.seed 1 \
186+
--random.enableEventSeed \
185187
--outputFile sim_dis_${{ matrix.beam }}_minQ2=${{ matrix.minq2 }}_${{ matrix.detector_config }}.edm4hep.root \
186188
-v WARNING
187189
- name: Upload ROOT output

0 commit comments

Comments
 (0)