Incorrect query string encoding with custom params

[jameslong]

Hi, I encounter HTML validation errors on the pagination links when using custom params.

To repro:

# Controller/context
params = %{"search" => %{"name" => "computer"}}
{:ok, kerosene} = Repo.paginate(Product, params)

# Template
<%= paginate @conn, @kerosene %>

which generates pagination links with the following query string:

?_utf8=%E2%9C%93&page=1&search[name]=computer

And HTML validation errors on w3 as follows:

Bad value /products?_utf8=%E2%9C%93&page=1&search[name]=computer for attribute href on element a: Illegal character in query: [ is not allowed.

The solution is to URL encode the [``] characters. I'm not sure what the recommended functions are to do this though!

[allyraza]

Thanks for reporting this, I will try and reproduce this and hopefully apply a patch soon.

[jung-hunsoo]

Is this bug fixed?

[allyraza]

@jung-hunsoo did you also have this issue I was unable to reproduce it

[allyraza]

I tried to reproduce @jameslong did i miss something

  def index(conn, _) do
    params = %{"search" => %{"name" => "computer"}}
    {products, kerosene} = Product
    # |> Product.top_ten
    |> Repo.paginate(params)

    render(conn, products: products, kerosene: kerosene)
  end

  <%= paginate(@conn, @kerosene, params: %{foo: "bar", "per_page": 1}) %>

# http://localhost:4000/products?foo=bar&page=2&per_page=1&search[name]=computer