Skip to content

header match based extproc - #9780

Draft
PatilHrushikesh wants to merge 6 commits into
envoyproxy:mainfrom
PatilHrushikesh:feat/extproc-matches-target-scope
Draft

header match based extproc#9780
PatilHrushikesh wants to merge 6 commits into
envoyproxy:mainfrom
PatilHrushikesh:feat/extproc-matches-target-scope

Conversation

@PatilHrushikesh

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #


PR Checklist

  • Authorship & ownership: Coding agents / AI assistants are welcome, but I have reviewed every change, understand how and why it works, can explain and maintain it, and take full responsibility for this PR. I have not submitted generated output I do not understand.
  • DCO: All commits are signed off (git commit -s). See DCO: Sign your work.
  • API agreed first: If this PR contains API changes (changes under /api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.
  • Required checks pass: make generate gen-check, make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, but gen-check, lint, and coverage MUST pass.)
  • Tests added/updated: New/changed code is covered by appropriate tests. N/A if this PR does not contain code changes.
  • Docs: User-facing changes update the docs, either in this PR or a follow-up PR. N/A if this PR does not contain user-facing changes.
  • Release notes: For any non-trivial change, added a release-note fragment under release-notes/current/<section>/<pr-number>-<slug>.md (see release-notes/current/README.md for sections and naming). N/A if this PR does not contain non-trivial changes.
  • Generated files committed: Ran make gen-check and committed the result if API/helm charts/modules changed.
  • Scope & compatibility: The PR is reasonably scoped (no unrelated changes) and preserves backward compatibility, or any breaking change is called out above and documented in release-notes/current/breaking_changes/.
  • Codex review: Requested a Codex review and addressed all of its comments.
  • Copilot review: Requested a Copilot review and addressed all of its comments.

Signed-off-by: Hrushikesh Patil <hrushi2900@gmail.com>
@netlify

netlify Bot commented Aug 18, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit bd230c9
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a86a55879ed4d0008303399
😎 Deploy Preview https://deploy-preview-9780--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.13043% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.27%. Comparing base (2b40195) to head (bd230c9).

Files with missing lines Patch % Lines
internal/xds/translator/extproc.go 64.94% 24 Missing and 10 partials ⚠️
internal/gatewayapi/envoyextensionpolicy.go 27.77% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9780      +/-   ##
==========================================
- Coverage   76.34%   76.27%   -0.07%     
==========================================
  Files         261      261              
  Lines       44440    44549     +109     
==========================================
+ Hits        33927    33980      +53     
- Misses       8269     8315      +46     
- Partials     2244     2254      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain

zirain commented Aug 20, 2026

Copy link
Copy Markdown
Member

I think the underlying layer is more universal (at least not just ExtProc), so we probably need a more generic API shape.
cc @envoyproxy/gateway-maintainers

@PatilHrushikesh

Copy link
Copy Markdown
Contributor Author

I think the underlying layer is more universal (at least not just ExtProc), so we probably need a more generic API shape. cc @envoyproxy/gateway-maintainers

so you are saying to have generic field for wasm and lua (and other) as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants