feat(api): add EnableCircuitBreakerRemainingStats to ProxyMetrics - #9805
Open
omkar619-dev wants to merge 1 commit into
Open
feat(api): add EnableCircuitBreakerRemainingStats to ProxyMetrics#9805omkar619-dev wants to merge 1 commit into
omkar619-dev wants to merge 1 commit into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb571e04bb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Adds an opt-in EnvoyProxy telemetry setting that enables Envoy's circuit breaker track_remaining field, exposing the remaining_* gauges that report how much headroom is left before a circuit breaker opens. The flag is applied to both the default-priority thresholds and the per-host thresholds. Clusters generated for ext-auth, ext-proc, JWT and OIDC providers are not covered, as they are built via createExtServiceXDSCluster which does not receive proxy telemetry context. This limitation is documented on the API field. Fixes envoyproxy#7743 Signed-off-by: Omkar Shendge <omkarshendge619@gmail.com>
omkar619-dev
force-pushed
the
feat/circuit-breaker-track-remaining
branch
from
August 20, 2026 05:19
cb571e0 to
0de22f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7743
Adds
enableCircuitBreakerRemainingStatstoEnvoyProxy.spec.telemetry.metrics, following @arkodg's preference for opt-in via EnvoyProxy rather than BackendTrafficPolicy. PlumbedProxyMetrics->ir.Metrics->internal/gatewayapi/listener.go->buildXdsClusterCircuitBreaker, mirroring the existingEnablePerEndpointStatspath.Set on both
ThresholdsandPerHostThresholds, per @guydc's note that per-host users are interested in this too.Not applied to ext-auth / ext-proc / jwt / oidc clusters: those are built via
createExtServiceXDSCluster(internal/xds/translator/utils.go), which never receivesmetrics. Documented on the API field godoc.One thing worth flagging from the Envoy proto: remaining retry resources are not tracked when a retry budget is used in place of the
max_retriescircuit breaker. Since Envoy Gateway already supportsretryBudget, I've documented that interaction on the field.Defaults to off, so all existing xDS golden fixtures pass unchanged. New fixture
circuit-breaker-track-remainingcovers both threshold types./cc @arkodg @guydc