Fix MuxIOThreadPoolExecutor::removeObserver re-adding the observer

ot · meta-codesync[bot] · commit 05fa8a246b7b · 2026-08-10T09:07:00.000-07:00
Summary: `removeObserver()` called `ThreadPoolExecutor::addObserver()` instead of `removeObserver()`, so removing an observer actually re-registered it.

Reviewed By: uvdn7

Differential Revision: D113780925

fbshipit-source-id: b809ee19c2aeafb41268a02b628b3192a695408c
diff --git a/folly/io/async/MuxIOThreadPoolExecutor.cpp b/folly/io/async/MuxIOThreadPoolExecutor.cpp
@@ -233,7 +233,7 @@ void MuxIOThreadPoolExecutor::maybeUnregisterEventBases(Observer* o) {
 
 void MuxIOThreadPoolExecutor::removeObserver(std::shared_ptr<Observer> o) {
   maybeUnregisterEventBases(o.get());
-  ThreadPoolExecutor::addObserver(std::move(o));
+  ThreadPoolExecutor::removeObserver(std::move(o));
 }
 
 std::vector<folly::Executor::KeepAlive<folly::EventBase>>

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ void MuxIOThreadPoolExecutor::maybeUnregisterEventBases(Observer* o) {`
`233`	`233`
`234`	`234`	`void MuxIOThreadPoolExecutor::removeObserver(std::shared_ptr<Observer> o) {`
`235`	`235`	`maybeUnregisterEventBases(o.get());`
`236`		`- ThreadPoolExecutor::addObserver(std::move(o));`
	`236`	`+ ThreadPoolExecutor::removeObserver(std::move(o));`
`237`	`237`	`}`
`238`	`238`
`239`	`239`	`std::vector<folly::Executor::KeepAlive<folly::EventBase>>`