Fix packaging workflows

My initial attempt at D90919043 only uncovered more failures,
so try and fix the remaining ones:
* Add missing entry for Ubuntu Noble to substcontrol.py.
* Run `install-system-packages.sh` in a venv to workaround the unconditional `pip install pex`
  call from getdeps. `pex` isn't actually relevant to the watchman build so this just needs to not fail.
* Reapply D93644456 so that we don't produce random shared libraries that conflict with system ones.
  This appears to have been unintentionally unfixed by D94714599.
* Build fast_float from source on Fedora < 42.
* Drop Fedora 40, add Fedora 43.
* Update third-party workflow versions as we're here.

Tested via:
* https://github.com/mszabo-wikia/watchman/actions/runs/23025768943
* https://github.com/mszabo-wikia/watchman/actions/runs/23025768938

Author: mszabo-wikia

.github/workflows/generate-release-yml.rs

@@ -35,7 +35,7 @@ fn parse_pattern(pattern: &String) -> Option<(Pattern, Vec<&'static str>)> {
     } else if pattern.contains("%FEDORA_STABLE_VERSION%") {
         Some((
             Box::new(move |p: &str, s: &str| p.replace("%FEDORA_STABLE_VERSION%", s)),
-            vec!["40", "41", "42"],
+            vec!["41", "42", "43"],
         ))
     } else {
         None

.github/workflows/package.yml

@@ -7,20 +7,20 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
 
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Build and push Docker image
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: .
           build-args: "UBUNTU_VERSION=24.04"
@@ -35,13 +35,17 @@ jobs:
       image: ${{ format('ghcr.io/{0}/watchman-build-env:latest', github.repository) }}
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: rustup default stable
         run: rustup default stable
 
       - name: Install system dependencies
-        run: ./install-system-packages.sh
+        shell: bash
+        run: |
+          python3 -m venv venv
+          source venv/bin/activate
+          ./install-system-packages.sh
 
       - name: Test cargo
         run: cargo --help
@@ -53,4 +57,6 @@ jobs:
         run: ./autogen.sh
 
       - name: Make .deb
+        env:
+          UBUNTU_VERSION: '24.04'
         run: ./watchman/build/package/make-deb.sh

.github/workflows/release.yml

@@ -32,17 +32,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: "${{ github.repository_owner }}"
           password: "${{ secrets.GITHUB_TOKEN }}"
       - name: Build and push Docker image
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: "."
           build-args: UBUNTU_VERSION=22.04
@@ -53,86 +53,86 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: "${{ github.repository_owner }}"
           password: "${{ secrets.GITHUB_TOKEN }}"
       - name: Build and push Docker image
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: "."
           build-args: UBUNTU_VERSION=24.04
           file: watchman/build/package/ubuntu-env/Dockerfile
           push: true
           tags: "${{ format('ghcr.io/{0}/watchman-build-env:ubuntu-24-latest', github.repository) }}"
-  docker-fedora-40:
+  docker-fedora-41:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: "${{ github.repository_owner }}"
           password: "${{ secrets.GITHUB_TOKEN }}"
       - name: Build and push Docker image
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: "."
-          build-args: FEDORA_VERSION=40
+          build-args: FEDORA_VERSION=41
           file: watchman/build/package/fedora-env/Dockerfile
           push: true
-          tags: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-40-latest', github.repository) }}"
-  docker-fedora-41:
+          tags: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-41-latest', github.repository) }}"
+  docker-fedora-42:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: "${{ github.repository_owner }}"
           password: "${{ secrets.GITHUB_TOKEN }}"
       - name: Build and push Docker image
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: "."
-          build-args: FEDORA_VERSION=41
+          build-args: FEDORA_VERSION=42
           file: watchman/build/package/fedora-env/Dockerfile
           push: true
-          tags: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-41-latest', github.repository) }}"
-  docker-fedora-42:
+          tags: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-42-latest', github.repository) }}"
+  docker-fedora-43:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: "${{ github.repository_owner }}"
           password: "${{ secrets.GITHUB_TOKEN }}"
       - name: Build and push Docker image
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: "."
-          build-args: FEDORA_VERSION=42
+          build-args: FEDORA_VERSION=43
           file: watchman/build/package/fedora-env/Dockerfile
           push: true
-          tags: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-42-latest', github.repository) }}"
+          tags: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-43-latest', github.repository) }}"
   clone-build-package-ubuntu-22:
     needs:
       - prepare
@@ -144,9 +144,10 @@ jobs:
       - name: Fix HOME
         run: echo HOME=/root >> $GITHUB_ENV
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Install system dependencies
-        run: "./install-system-packages.sh"
+        shell: bash
+        run: "python3 -m venv venv\nsource venv/bin/activate\n./install-system-packages.sh\n"
       - name: Fix dubious ownership
         run: git config --global --add safe.directory /__w/watchman/watchman
       - name: Build Watchman binaries
@@ -175,9 +176,10 @@ jobs:
       - name: Fix HOME
         run: echo HOME=/root >> $GITHUB_ENV
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Install system dependencies
-        run: "./install-system-packages.sh"
+        shell: bash
+        run: "python3 -m venv venv\nsource venv/bin/activate\n./install-system-packages.sh\n"
       - name: Fix dubious ownership
         run: git config --global --add safe.directory /__w/watchman/watchman
       - name: Build Watchman binaries
@@ -195,28 +197,29 @@ jobs:
           asset_path: /_debs/watchman.deb
           asset_name: "watchman_ubuntu24.04_${{ needs.prepare.outputs.release }}.deb"
           asset_content_type: application/x-deb
-  clone-build-package-fedora-40:
+  clone-build-package-fedora-41:
     needs:
       - prepare
-      - docker-fedora-40
+      - docker-fedora-41
     runs-on: ubuntu-latest
     container:
-      image: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-40-latest', github.repository) }}"
+      image: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-41-latest', github.repository) }}"
     steps:
       - name: Fix HOME
         run: echo HOME=/root >> $GITHUB_ENV
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Install system dependencies
-        run: "./install-system-packages.sh"
+        shell: bash
+        run: "python3 -m venv venv\nsource venv/bin/activate\n./install-system-packages.sh\n"
       - name: Fix dubious ownership
         run: git config --global --add safe.directory /__w/watchman/watchman
       - name: Build Watchman binaries
         run: "./autogen.sh"
       - name: Make .rpm
         id: make_rpm
         env:
-          FEDORA_VERSION: "40"
+          FEDORA_VERSION: "41"
         run: "./watchman/build/package/make-rpm.sh"
       - name: Upload .rpm
         env:
@@ -227,28 +230,29 @@ jobs:
           asset_path: "${{ steps.make_rpm.outputs.rpm_path }}"
           asset_name: "${{ steps.make_rpm.outputs.rpm_name }}"
           asset_content_type: application/x-rpm
-  clone-build-package-fedora-41:
+  clone-build-package-fedora-42:
     needs:
       - prepare
-      - docker-fedora-41
+      - docker-fedora-42
     runs-on: ubuntu-latest
     container:
-      image: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-41-latest', github.repository) }}"
+      image: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-42-latest', github.repository) }}"
     steps:
       - name: Fix HOME
         run: echo HOME=/root >> $GITHUB_ENV
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Install system dependencies
-        run: "./install-system-packages.sh"
+        shell: bash
+        run: "python3 -m venv venv\nsource venv/bin/activate\n./install-system-packages.sh\n"
       - name: Fix dubious ownership
         run: git config --global --add safe.directory /__w/watchman/watchman
       - name: Build Watchman binaries
         run: "./autogen.sh"
       - name: Make .rpm
         id: make_rpm
         env:
-          FEDORA_VERSION: "41"
+          FEDORA_VERSION: "42"
         run: "./watchman/build/package/make-rpm.sh"
       - name: Upload .rpm
         env:
@@ -259,28 +263,29 @@ jobs:
           asset_path: "${{ steps.make_rpm.outputs.rpm_path }}"
           asset_name: "${{ steps.make_rpm.outputs.rpm_name }}"
           asset_content_type: application/x-rpm
-  clone-build-package-fedora-42:
+  clone-build-package-fedora-43:
     needs:
       - prepare
-      - docker-fedora-42
+      - docker-fedora-43
     runs-on: ubuntu-latest
     container:
-      image: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-42-latest', github.repository) }}"
+      image: "${{ format('ghcr.io/{0}/watchman-build-env:fedora-43-latest', github.repository) }}"
     steps:
       - name: Fix HOME
         run: echo HOME=/root >> $GITHUB_ENV
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Install system dependencies
-        run: "./install-system-packages.sh"
+        shell: bash
+        run: "python3 -m venv venv\nsource venv/bin/activate\n./install-system-packages.sh\n"
       - name: Fix dubious ownership
         run: git config --global --add safe.directory /__w/watchman/watchman
       - name: Build Watchman binaries
         run: "./autogen.sh"
       - name: Make .rpm
         id: make_rpm
         env:
-          FEDORA_VERSION: "42"
+          FEDORA_VERSION: "43"
         run: "./watchman/build/package/make-rpm.sh"
       - name: Upload .rpm
         env:
@@ -296,7 +301,7 @@ jobs:
     needs: prepare
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Build watchman
         run: "python3 build/fbcode_builder/getdeps.py build --src-dir=. watchman  --project-install-prefix watchman:/usr/local"
       - name: Copy artifacts