Skip to content

Commit 1cbb823

Browse files
committed
Added item data for domain average wind speed units to fix bug setting meters per second
1 parent cddf2c9 commit 1cbb823

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

src/gui/domainAverageInput.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,15 @@ DomainAverageInput::DomainAverageInput(Ui::MainWindow* ui, QObject* parent)
3939

4040
ui->domainAverageTable->setTabKeyNavigation(false);
4141

42+
ui->inputWindHeightUnitsComboBox->setItemData(0, "ft");
43+
ui->inputWindHeightUnitsComboBox->setItemData(1, "m");
44+
45+
ui->tableSpeedUnits->setItemData(0, "mph");
46+
ui->tableSpeedUnits->setItemData(1, "mps");
47+
ui->tableSpeedUnits->setItemData(2, "kph");
48+
ui->tableSpeedUnits->setItemData(3, "kts");
49+
50+
4251
spinBoxLineEditWasBlank = false;
4352

4453
connect(ui->inputWindHeightComboBox, &QComboBox::currentIndexChanged, this, &DomainAverageInput::windHeightComboBoxCurrentIndexChanged);

src/gui/mainWindow.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ void MainWindow::solveButtonClicked()
513513
}
514514

515515
bool momentumFlag = ui->momentumSolverCheckBox->isChecked();
516-
QString speedUnits = ui->tableSpeedUnits->currentText();
516+
QString speedUnits = ui->tableSpeedUnits->itemData(ui->tableSpeedUnits->currentIndex()).toString();
517517
QString airTempUnits = ui->tableTempUnits->currentText().remove("°");
518518
QString cloudCoverUnits = "percent";
519519
if(ninjaErr == NINJA_SUCCESS)

src/gui/outputs.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ Outputs::Outputs(Ui::MainWindow *ui,
99
ui->outputDirectoryLineEdit->setText(downloadsPath);
1010
ui->outputDirectoryButton->setIcon(QIcon(":/folder.png"));
1111

12-
ui->inputWindHeightUnitsComboBox->setItemData(0, "ft");
13-
ui->inputWindHeightUnitsComboBox->setItemData(1, "m");
1412
ui->outputWindHeightUnitsComboBox->setItemData(0, "ft");
1513
ui->outputWindHeightUnitsComboBox->setItemData(1, "m");
1614
ui->meshResolutionUnitsComboBox->setItemData(0, "m");

src/ninja/windninja.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ WINDNINJADLL_EXPORT NinjaArmyH* NinjaInitializeArmy()
114114
* \param numNinjas The number of runs to create.
115115
* \param momentumFlag Flag specifying if the mass and momentum solver should be used.
116116
* \param speedList List of wind speeds to simulate.
117-
* \param speedUnits String indicating wind speed units ("mph", "mps", "kph", "knots").
117+
* \param speedUnits String indicating wind speed units ("mph", "mps", "kph", "kts").
118118
* \param directionList List of wind directions to simulate in degrees.
119119
* \param yearList List of years to simulate (only needed if diurnal or stability is going to be used), can be NULL.
120120
* \param monthList List of months to simulate (only needed if diurnal or stability is going to be used), can be NULL.
@@ -159,7 +159,7 @@ WINDNINJADLL_EXPORT NinjaErr NinjaMakeDomainAverageArmyThermalParameterization
159159
* \param numNinjas The number of runs to create.
160160
* \param momentumFlag Flag specifying if the mass and momentum solver should be used.
161161
* \param speedList List of wind speeds to simulate.
162-
* \param speedUnits String indicating wind speed units ("mph", "mps", "kph", "knots").
162+
* \param speedUnits String indicating wind speed units ("mph", "mps", "kph", "kts").
163163
* \param directionList List of wind directions to simulate in degrees.
164164
*
165165
* \return NINJA_SUCCESS on success, non-zero otherwise.

0 commit comments

Comments
 (0)