Added the skip_verification option. - #85
Merged
Merged
Conversation
This option is intended for users who prefer to verify the JWT token elsewhere while still leveraging other features provided by the module.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 94.83% 95.05% +0.22%
==========================================
Files 2 2
Lines 329 344 +15
==========================================
+ Hits 312 327 +15
Misses 12 12
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Owner
|
LGTM, thanks for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is intended for users who prefer to verify the JWT token elsewhere while still leveraging other features provided by the module.
All the details are provided in the comment for SkipVerification in jwt.go. In short, we verify the token after the Caddy proxy in the upstreams, but we still need the other features offered by the plugin, especially parsing and populating user metadata.
Hopefully it would be useful for other people as well.
Thanks.