fix: preserve live thinking config#5812
Conversation
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! This PR is a bug fix, and while you have provided a detailed "To verify" section, could you please also:
This information will help our reviewers review your PR more efficiently. Thanks! |
40f5ae3 to
eb4aa44
Compare
|
Rebased this branch onto current Validation on Windows: The warnings are the existing experimental feature warnings from this test file. |
eb4aa44 to
80118cc
Compare
|
Rebased onto current main again; no code changes beyond the rebase.\n\nValidation on Windows:\n- uv run --no-sync pytest tests\unittests\models\test_google_llm.py::test_connect_copies_thinking_config_to_live_config -q --basetemp .tmp\pytest-5812-20260524 -p no:cacheprovider -> 1 passed\n- uv run --no-sync pytest tests\unittests\models\test_google_llm.py -q --basetemp .tmp\pytest-5812-full-20260524 -p no:cacheprovider -> 62 passed, 3 existing experimental warnings\n- uv run --no-sync pyink --check src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.py\n- uv run --no-sync python -m py_compile src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.py\n- git diff --check upstream/main..HEAD |
Summary
GenerateContentConfig.thinking_configinto the Gemini live connect configaio.live.connect()receives the thinking configTo verify
uv run pytest tests/unittests/models/test_google_llm.py -quv run pyink --check src/google/adk/models/google_llm.py tests/unittests/models/test_google_llm.pypython -m py_compile C:\dev\GITHUB-clean\adk-python\src\google\adk\models\google_llm.py C:\dev\GITHUB-clean\adk-python\tests\unittests\models\test_google_llm.pygit diff --check -- src/google/adk/models/google_llm.py tests/unittests/models/test_google_llm.pyFixes #5805