In an RBE set-up, that requires all the inputs to be declared as they are sent to the worker, the mentioned
test fails with:
--
# RUN: at line 1
/var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/xls_opt --arith-to-xls --xls-lower --canonicalize /var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/testdata/integration/addf.mlir | /var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/xls_translate --mlir-xls-to-xls --main-function=add16 -o /var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/testdata/integration/Output/addf.mlir.tmp
# executed command: /var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/xls_opt --arith-to-xls --xls-lower --canonicalize /var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/testdata/integration/addf.mlir
# executed command: /var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/xls_translate --mlir-xls-to-xls --main-function=add16 -o /var/lib/rbe-runner/worker-1/build/9f89258d9ad0c5cd/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/testdata/integration/Output/addf.mlir.tmp
# .---command stderr------------
# | Failed to find DSLX file: xls/dslx/stdlib/bfloat16.x
# `-----------------------------
# error: command failed with exit status: 1
So I suspect around here-ish the file is not found via
https://github.com/google/xls/blob/main/xls/contrib/mlir/tools/xls_translate/xls_translate_from_mlir.cc#L1026
When looking at the status, I get a
UNKNOWN: Failed to initialize Runfiles: ERROR: external/rules_cc+/cc/runfiles/runfiles.cc(103): cannot find runfiles (argv0="/var/lib/rbe-runner/worker-1/build/7db5b53ff006e700/root/bazel-out/k8-opt/bin/xls/contrib/mlir/testdata/integration/addf.mlir.test.runfiles/_main/xls/contrib/mlir/xls_translate") ]
So, might be either some missing data=[] somewhere that adds the bfloat16.x file, or maybe the runfiles don't work properly on the RBE ? (however, all the other XLS tests pass, and there are a lot that
I don't know what lit_test() is (where this test is put together), but maybe it is a rule that should explicitly pass on runfiles ? xls/contrib/mlir/testdata/BUILD.bazel also excludes some other tests due to RUNFILE issues, maybe that is already a known issue.
In an RBE set-up, that requires all the inputs to be declared as they are sent to the worker, the mentioned
test fails with:
So I suspect around here-ish the file is not found via
https://github.com/google/xls/blob/main/xls/contrib/mlir/tools/xls_translate/xls_translate_from_mlir.cc#L1026
When looking at the status, I get a
So, might be either some missing
data=[]somewhere that adds the bfloat16.x file, or maybe the runfiles don't work properly on the RBE ? (however, all the other XLS tests pass, and there are a lot thatI don't know what
lit_test()is (where this test is put together), but maybe it is a rule that should explicitly pass on runfiles ?xls/contrib/mlir/testdata/BUILD.bazelalso excludes some other tests due to RUNFILE issues, maybe that is already a known issue.