Skip to content

stats/opentelemetry: set ai.method in clientTracingHandler.TagRPC #9116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

stats/opentelemetry: set ai.method in clientTracingHandler.TagRPC #9116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55a71d4
stats/opentelemetry: set ai.method in clientTracingHandler.TagRPC
c-tonneslan May 11, 2026
83ff861
stats/opentelemetry: add test for method name in span with trace-only…
c-tonneslan May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stats/opentelemetry/client_tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ func (h *clientTracingHandler) TagRPC(ctx context.Context, info *stats.RPCTagInf
logger.Error("context passed into client side stats handler (TagRPC) has no call info")
return ctx
}
ri.ai.method = removeLeadingSlash(info.FullMethodName)
Copy link
Copy Markdown
Contributor

@mbissa mbissa May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that verifies that it works without metrics handler?

ctx = h.traceTagRPC(ctx, ri.ai, info.NameResolutionDelay)
return ctx
}
Expand Down
Loading