all: fix SA5011 reports from redundant nil checks inferring nil possibility

Author: joshuasing

bitcoin/wallet/gozer/tbcgozer/tbcgozer_test.go

@@ -489,9 +489,6 @@ func TestTBCGozerTxByID(t *testing.T) {
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}
-	if tx == nil {
-		t.Fatal("expected non-nil tx")
-	}
 	if tx.Version != 2 {
 		t.Fatalf("expected version 2, got %v", tx.Version)
 	}

bitcoin/wallet/wallet_pop_test.go

@@ -272,9 +272,6 @@ func TestPoPPrevOutsFetcherRoundTrip(t *testing.T) {
 
 	fetcher := prevOutsFetcher(prevOuts)
 	got := fetcher.FetchPrevOutput(f.outpoint)
-	if got == nil {
-		t.Fatal("fetcher returned nil for known outpoint (key parse failure)")
-	}
 	if got.Value != int64(f.utxo.Value) {
 		t.Fatalf("fetcher value mismatch: got %d want %d",
 			got.Value, int64(f.utxo.Value))

bitcoin/wallet/wallet_test.go

@@ -228,9 +228,6 @@ func TestIntegration(t *testing.T) {
 	if err != nil {
 		t.Fatalf("TxByID after broadcast: %v", err)
 	}
-	if lookedUp == nil {
-		t.Fatal("TxByID returned nil tx")
-	}
 	if len(lookedUp.TxIn) == 0 {
 		t.Fatal("TxByID returned tx with no inputs")
 	}

service/tbc/cpfp_test.go

@@ -205,18 +205,12 @@ func TestTxOutByOutpoint(t *testing.T) {
 
 	// Index 0 should return the first output.
 	out := mp.txOutByOutpoint(parentHash, 0)
-	if out == nil {
-		t.Fatal("expected output at index 0")
-	}
 	if out.Value != 50_000 {
 		t.Fatalf("expected value 50000, got %d", out.Value)
 	}
 
 	// Index 1 should return the second output.
 	out = mp.txOutByOutpoint(parentHash, 1)
-	if out == nil {
-		t.Fatal("expected output at index 1")
-	}
 	if out.Value != 30_000 {
 		t.Fatalf("expected value 30000, got %d", out.Value)
 	}