ci: use uv.lock when running tests - #9214
Merged
Merged
Conversation
Contributor
Author
This is misleading because this doesn't change a python file, so it didn't actually run the python tests. |
Contributor
Author
I figured |
Pfannkuchensack
approved these changes
Jun 5, 2026
lstein
approved these changes
Jun 8, 2026
lstein
enabled auto-merge (squash)
June 11, 2026 19:55
4 tasks
lstein
added a commit
that referenced
this pull request
Jun 11, 2026
PR #9214 switched dependency installation from 'uv pip install' (which honored UV_SYSTEM_PYTHON=1 and installed into the system Python) to 'uv sync', which always installs into a project-local .venv. The bare 'pytest' invocation in the next step never saw that venv, failing with 'pytest: command not found' (exit 127) on every matrix job. - Run pytest via 'uv run --no-sync pytest'. The --no-sync flag is required: a plain 'uv run' would re-sync without '--extra test' and uninstall pytest before running it. - Drop UV_SYSTEM_PYTHON=1, which is dead config now that nothing uses the 'uv pip' interface. - Drop the actions/setup-python step; setup-uv is already given the matrix python-version and uv sync provisions its own interpreter. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
dunkeroni
pushed a commit
to dunkeroni/InvokeAI
that referenced
this pull request
Jun 29, 2026
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com> Co-authored-by: Alexander Eichhorn <alex@eichhorn.dev> Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
dunkeroni
pushed a commit
to dunkeroni/InvokeAI
that referenced
this pull request
Jun 29, 2026
PR invoke-ai#9214 switched dependency installation from 'uv pip install' (which honored UV_SYSTEM_PYTHON=1 and installed into the system Python) to 'uv sync', which always installs into a project-local .venv. The bare 'pytest' invocation in the next step never saw that venv, failing with 'pytest: command not found' (exit 127) on every matrix job. - Run pytest via 'uv run --no-sync pytest'. The --no-sync flag is required: a plain 'uv run' would re-sync without '--extra test' and uninstall pytest before running it. - Drop UV_SYSTEM_PYTHON=1, which is dead config now that nothing uses the 'uv pip' interface. - Drop the actions/setup-python step; setup-uv is already given the matrix python-version and uv sync provisions its own interpreter. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given we run a "uv lock checks" workflow, I assume that means we intend uv.lock to be used.
The
uv pipinterface is a different thing than the rest of uv (sync,run, etc), it doesn't useuv.lock(but can use version constraints expressed in other ways). Useuv syncinstead.Checklist
What's Newcopy (if doing a release after this PR)