Skip to content

Commit afd4137

Browse files
authored
Merge pull request #488 from jaredwray/claude/writr-engines-node-shq7ah
root - fix: allow Node 24+ in engines.node
2 parents cdb382f + f70fa36 commit afd4137

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

.github/workflows/writr-rs.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,12 @@ jobs:
118118
run: HARNESS_ENGINE=writr-rust WRITR_RS_FORCE_WASM=1 pnpm test:harness
119119
- name: Browser smoke (Chromium)
120120
run: |
121-
npx playwright-core install chromium --with-deps || npx playwright install chromium --with-deps
121+
# Install browsers with the same playwright-core the smoke test loads.
122+
# browser-smoke.mjs requires playwright-core from crates/writr-node, so
123+
# running the installer from the repo root — where it is not a dependency —
124+
# makes npx fetch the newest release instead and download a browser build
125+
# the pinned copy cannot launch.
126+
(cd writr-rs/crates/writr-node && pnpm exec playwright-core install chromium --with-deps)
122127
node writr-rs/tools/browser-smoke.mjs
123128
- name: JS suite untouched
124129
run: pnpm test:ci

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
},
2323
"author": "Jared Wray <me@jaredwray.com>",
2424
"engines": {
25-
"node": "^22.18.0"
25+
"node": "^22.18.0 || >=24.0.0"
2626
},
2727
"license": "MIT",
2828
"keywords": [

0 commit comments

Comments
 (0)