RTECO-945 - Fix golangci-lint errors in apk_test.go and buildtools/cli.go

- errcheck: replace defer os.RemoveAll with clientTestUtils.RemoveAllAndAssert
  so the error return is not silently dropped (apk_test.go lines 658, 761)
- ineffassign: reassigned args is never read after ExtractBoolFlagFromArgs;
  use _ to make the intent explicit (buildtools/cli.go line 2215)

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: naveenku-jfrog

apk_test.go

@@ -655,7 +655,7 @@ func TestApkFetch_Passthrough(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed to create temp dir: %v", err)
 	}
-	defer os.RemoveAll(tmpDir)
+	defer clientTestUtils.RemoveAllAndAssert(t, tmpDir)
 
 	jfrogCli := coretests.NewJfrogCli(execMain, "jfrog", "")
 	fetchErr := jfrogCli.Exec("apk", "fetch", "--output", tmpDir, "curl")
@@ -758,7 +758,7 @@ func TestApkUpload_LocalApkFile(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed to create temp dir: %v", err)
 	}
-	defer os.RemoveAll(tmpDir)
+	defer clientTestUtils.RemoveAllAndAssert(t, tmpDir)
 
 	// Build a minimal .apk (tgz containing just a PKGINFO) via abuild-tar or tar.
 	// If abuild-tar is not available, skip gracefully.

buildtools/cli.go

@@ -2212,7 +2212,7 @@ func apkConfigSubCmd(args []string, serverDetails *coreConfig.ServerDetails, rep
 	if branch == "" {
 		branch = "main"
 	}
-	args, applyFlag, err := coreutils.ExtractBoolFlagFromArgs(args, "apply")
+	_, applyFlag, err := coreutils.ExtractBoolFlagFromArgs(args, "apply")
 	if err != nil {
 		return errorutils.CheckErrorf("failed to extract --apply: %w", err)
 	}