Skip to content

Allow conditional creation of metrics server APIService #892

Description

@GusAntoniassi

Use-Case

We are using an implementation based on external-metrics-multiplexer to be able to use KEDA alongside kube-metrics-adapter, to allow a more phased out migration of our scaling workloads to KEDA.

Currently, there is no way to disable the creation of KEDA's v1beta1.external.metrics.k8s.io APIService in this chart. The only flag in apiservice.yaml is metricsServer.enabled, however we still need the metricsServer deployment for this multiplexer scenario.

Specification

  • Add value metricsServer.createApiService (bool, default true) to gate only the APIService creation

Proposed change

In templates/metrics-server/apiservice.yaml:

- {{- if .Values.metricsServer.enabled }}
+ {{- if and .Values.metricsServer.enabled (.Values.metricsServer.createApiService | default true) }}

Defaulting to true via | default true preserves existing behavior for all users.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions