Skip to content

Fix dark mode styling for disabled GPU dialog#804

Open
CodeVishal-17 wants to merge 3 commits into
kubeflow:mainfrom
CodeVishal-17:fix-darkmode-gpu-dialog
Open

Fix dark mode styling for disabled GPU dialog#804
CodeVishal-17 wants to merge 3 commits into
kubeflow:mainfrom
CodeVishal-17:fix-darkmode-gpu-dialog

Conversation

@CodeVishal-17
Copy link
Copy Markdown
Contributor

fixes #785

Summary

Fixes dark mode UI inconsistencies in the disabled GPU dialog.

Changes

  • Improved disabled input visibility in dark mode
  • Added better contrast for disabled fields
  • Unified styling between GPU Count and GPU Type fields
  • Improved readability and overall dark mode consistency

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: CodeVishal-17 <vishal.goyal7711@gmail.com>
@CodeVishal-17 CodeVishal-17 force-pushed the fix-darkmode-gpu-dialog branch from cd43ea8 to 221114d Compare May 20, 2026 12:31
Copy link
Copy Markdown
Collaborator

@ada333 ada333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeVishal-17 thanks for the changes!

the input fields look different:

Image

also there is code duplication since you are using the same style twice

Could you please try to fix the code changes so the input fields (on all dialogs) look the same and there is minimal code duplication?

Signed-off-by: CodeVishal-17 <vishal.goyal7711@gmail.com>
@google-oss-prow google-oss-prow Bot added size/XS and removed size/S labels May 20, 2026
@CodeVishal-17
Copy link
Copy Markdown
Contributor Author

Thanks for the review! I updated the implementation to reduce code duplication and aligned the disabled input styling more closely with the existing dialog styles.

@google-oss-prow google-oss-prow Bot added the lgtm label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] The disabled GPU dialog in Jupyter Lab dark mode looks weird

2 participants