Add default empty callback to prevent exception when being called from a certain logic flow

machawk1 · machawk1 · commit dc77a1c1f076 · 2025-08-27T15:56:04.000-04:00
diff --git a/mink-plugin/options.js b/mink-plugin/options.js
@@ -346,7 +346,7 @@ function populateDropdownWithAggregatorsInStorage (arrayOfAggregators) {
   }
 }
 
-function setAggregatorsInStorage (arrayOfAggregatorHostnames, cb) {
+function setAggregatorsInStorage (arrayOfAggregatorHostnames, cb = ()) {
   // Returns a promise
   return chrome.storage.local.set({ 'aggregators': arrayOfAggregatorHostnames }).then(() => {
     console.log('Attempting to invoke the callback, this is failing w/ reload')

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ function populateDropdownWithAggregatorsInStorage (arrayOfAggregators) {`
`346`	`346`	`}`
`347`	`347`	`}`
`348`	`348`
`349`		`-function setAggregatorsInStorage (arrayOfAggregatorHostnames, cb) {`
	`349`	`+function setAggregatorsInStorage (arrayOfAggregatorHostnames, cb = ()) {`
`350`	`350`	`// Returns a promise`
`351`	`351`	`return chrome.storage.local.set({ 'aggregators': arrayOfAggregatorHostnames }).then(() => {`
`352`	`352`	`console.log('Attempting to invoke the callback, this is failing w/ reload')`