-
Notifications
You must be signed in to change notification settings - Fork 13
Expand file tree
/
Copy pathBUGS
More file actions
21 lines (16 loc) · 668 Bytes
/
Copy pathBUGS
File metadata and controls
21 lines (16 loc) · 668 Bytes
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
* next_runnable_job() ignores dependencies
* command= parsed, but methods.start= used instead
* EnvironmentVariables not actually implemented anymore. They parse, but not inserted into db.
* Lame idiom:
success = sqlite3_prepare_v2(dbh, sql, -1, &stmt, 0) == SQLITE_OK &&
sqlite3_bind_int64(stmt, 1, job->row_id) == SQLITE_OK &&
sqlite3_step(stmt) == SQLITE_DONE;
Replace with:
if (sqlite3_prepare_v2(dbh, sql, -1, &stmt, 0) != SQLITE_OK ||
sqlite3_bind_int64(stmt, 1, pid) != SQLITE_OK ||
sqlite3_bind_int64(stmt, 2, job->row_id) != SQLITE_OK ||
sqlite3_step(stmt) != SQLITE_DONE)
{
db_log_error(sqlite3_finalize(stmt));
return (-1);
}