bug fix. This cost me multiple hours

Author: njyeung

player/player.go

@@ -20,7 +20,6 @@ type AVPlayer struct {
 	playing atomic.Bool
 	paused  atomic.Bool
 	muted   atomic.Bool
-	closed  atomic.Bool
 	volume  atomic.Value // float64, 0.0–1.0
 
 	playMu   sync.Mutex
@@ -137,10 +136,6 @@ func (p *AVPlayer) Play(videoPath, pfpPath string) error {
 	p.playMu.Lock()
 	defer p.playMu.Unlock()
 
-	if p.closed.Load() {
-		return nil
-	}
-
 	p.playing.Store(true)
 	p.paused.Store(false)
 
@@ -275,11 +270,6 @@ func (p *AVPlayer) ClearGifs() {
 // Waits for the Play goroutine to finish before clearing terminal images,
 // preventing a race where frames render after cleanup.
 func (p *AVPlayer) Close() {
-	// Prevent any queued Play() goroutines from starting a new session
-	// after we release playMu. Without this, a pending Play() can grab
-	// playMu before us and override playing=true, deadlocking Close().
-	p.closed.Store(true)
-
 	// Signal for the session to stop playing
 	p.Stop()
 

player/session.go

@@ -7,6 +7,7 @@ import (
 	_ "image/jpeg"
 	"math"
 	"os"
+	"runtime"
 	"sync"
 	"time"
 	"unsafe"
@@ -190,6 +191,21 @@ func (s *playSession) audioDecodeLoop() {
 
 // demuxLoop reads packets and distributes them to audio/video channels
 func (s *playSession) demuxLoop(p *AVPlayer) {
+	// - programmer: Magic ahhh line to prevent freezing bug on quick scrolling input.
+	// 		Adding print statements here to debug caused the issue to disappear.
+	// 		Therefore we don't know the issue, but we only know the solution.
+	// 		Even opus does not know the issue. And bro's sorta the goat.
+	// 		So I give up.
+	// 		Like how this yields to the OS scheduler, I too, yield to this bug.
+	//
+	// - opus: For what it's worth, we DO know the issue — CGo FFmpeg ReadPacket
+	//   	calls in a tight loop starve the Go scheduler, preventing videoRenderLoop
+	//   	from being scheduled to respond to stopCh.
+	//
+	//
+	// DO NOT TOUCH THIS
+	runtime.Gosched()
+
 	defer close(s.videoPktCh)
 
 	for p.playing.Load() {