Skip to content

Commit d4249d4

Browse files
authored
Reduce log level for http errors (#2363)
Part of OPS-4531
1 parent cd8faf5 commit d4249d4

2 files changed

Lines changed: 17 additions & 6 deletions

File tree

packages/blocks/common/src/lib/http/axios/axios-http-client.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { logger } from '@openops/server-shared';
2+
import { extractPropertyString } from '@openops/shared';
23
import axios, { AxiosRequestConfig } from 'axios';
34
import { BaseHttpClient } from '../core/base-http-client';
45
import { DelegatingAuthenticationConverter } from '../core/delegating-authentication-converter';
@@ -49,7 +50,17 @@ export class AxiosHttpClient extends BaseHttpClient {
4950
body: response.data,
5051
};
5152
} catch (error) {
52-
logger.error('Failed to execute HTTP request.', error);
53+
logger.warn('Failed to execute HTTP request.', {
54+
method: request.method,
55+
url: request.url,
56+
errorMessage: extractPropertyString(error, ['message']),
57+
statusCode: axios.isAxiosError(error)
58+
? error.response?.status
59+
: undefined,
60+
responseData: axios.isAxiosError(error)
61+
? error.response?.data
62+
: undefined,
63+
});
5364

5465
if (axios.isAxiosError(error)) {
5566
throw new HttpError(request.body, error);

packages/openops/src/lib/axios-wrapper.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,22 +34,22 @@ export async function makeHttpRequest<T>(
3434
return response.data;
3535
} catch (error) {
3636
const axiosError = error as AxiosError;
37-
const logMessage = `Error making HTTP request. Url: "${url}"`;
37+
const logMessage = `Failed to execute HTTP request. Url: "${url}"`;
3838
const timeTaken = `${Math.floor(performance.now() - startTimeCode)}ms`;
3939

4040
if (axiosError && axiosError.response?.data) {
41-
logger.error(logMessage, {
41+
logger.warn(logMessage, {
42+
timeTaken,
4243
error: axiosError,
43-
errorResponse: axiosError.response?.data,
4444
status: axiosError.response?.status,
45+
errorResponse: axiosError.response?.data,
4546
statusText: axiosError.response?.statusText,
46-
timeTaken,
4747
});
4848

4949
throw new Error(JSON.stringify(axiosError.response?.data));
5050
}
5151

52-
logger.error(logMessage, {
52+
logger.warn(logMessage, {
5353
error,
5454
timeTaken,
5555
});

0 commit comments

Comments
 (0)