Skip to content

[release-4.18] OCPBUGS-86219: Add test for CPMS OnDelete strategy with full master replacement#31195

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-31054-to-release-4.18
Open

[release-4.18] OCPBUGS-86219: Add test for CPMS OnDelete strategy with full master replacement#31195
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-31054-to-release-4.18

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #31054

/assign hasbro17

Creates a new test case that validates the ControlPlaneMachineSet OnDelete
strategy by deleting all three master machines simultaneously and verifying
CPMS correctly replaces them while maintaining cluster health.

The test switches CPMS to OnDelete strategy, deletes all master machines,
and validates that CPMS creates replacements with proper etcd membership
transitions. Verifies that all old etcd members are removed from both the
cluster and etcd-endpoints ConfigMap, and new members are properly integrated.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-85275 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.18] OCPBUGS-86219: Add test for CPMS OnDelete strategy with full master replacement

Details

In response to this:

This is an automated cherry-pick of #31054

/assign hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ca4b2838-b327-4c01-94a3-f5af8308bccc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot changed the title [release-4.18] OCPBUGS-85275: Add test for CPMS OnDelete strategy with full master replacement [release-4.18] OCPBUGS-86219: Add test for CPMS OnDelete strategy with full master replacement May 19, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-86219, which is invalid:

  • expected dependent Jira Issue OCPBUGS-85275 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #31054

/assign hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from hasbro17 and rphillips May 19, 2026 18:09
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign hasbro17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 2b535a1 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn 2b535a1 link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade 2b535a1 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-edge-zones 2b535a1 link true /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants