Send back flash messages on section action error. wp/72005

Author: dfriquet

app/controllers/admin/settings/project_custom_field_sections_controller.rb

@@ -74,7 +74,7 @@ def destroy
         update_header_via_turbo_stream(allow_custom_field_creation: allow_custom_field_creation?)
         update_sections_via_turbo_stream(project_custom_field_sections: ProjectCustomFieldSection.all)
       else
-        # TODO: show error message
+        render_section_error_via_turbo_stream(call)
       end
 
       respond_with_turbo_streams
@@ -88,7 +88,7 @@ def move
       if call.success?
         update_sections_via_turbo_stream(project_custom_field_sections: ProjectCustomFieldSection.all)
       else
-        # TODO: show error message
+        render_section_error_via_turbo_stream(call)
       end
 
       respond_with_turbo_streams
@@ -103,7 +103,7 @@ def drop
         update_header_via_turbo_stream(allow_custom_field_creation: allow_custom_field_creation?)
         update_sections_via_turbo_stream(project_custom_field_sections: ProjectCustomFieldSection.all)
       else
-        # TODO: show error message
+        render_section_error_via_turbo_stream(call)
       end
       respond_with_turbo_streams
     end
@@ -114,6 +114,14 @@ def new_link
 
     private
 
+    # Show a danger toast with the action's hint (resolved relative to the
+    # controller/action), appending the service's error detail (e.g. why a
+    # non-empty section cannot be deleted) when present.
+    def render_section_error_via_turbo_stream(call)
+      message = [t(".error"), call.message].compact_blank.join(" ")
+      render_error_flash_message_via_turbo_stream(message:)
+    end
+
     def set_project_custom_field_section
       @project_custom_field_section = ProjectCustomFieldSection.find(params[:id])
     end

app/controllers/admin/settings/user_custom_field_sections_controller.rb

@@ -72,7 +72,8 @@ def destroy
       if call.success?
         update_header_via_turbo_stream(allow_custom_field_creation: allow_custom_field_creation?)
         update_sections_via_turbo_stream(user_custom_field_sections: UserCustomFieldSection.all)
-        # TODO: show error message on failure
+      else
+        render_section_error_via_turbo_stream(call)
       end
 
       respond_with_turbo_streams
@@ -85,7 +86,8 @@ def move
 
       if call.success?
         update_sections_via_turbo_stream(user_custom_field_sections: UserCustomFieldSection.all)
-        # TODO: show error message on failure
+      else
+        render_section_error_via_turbo_stream(call)
       end
 
       respond_with_turbo_streams
@@ -99,7 +101,8 @@ def drop
       if call.success?
         update_header_via_turbo_stream(allow_custom_field_creation: allow_custom_field_creation?)
         update_sections_via_turbo_stream(user_custom_field_sections: UserCustomFieldSection.all)
-        # TODO: show error message on failure
+      else
+        render_section_error_via_turbo_stream(call)
       end
 
       respond_with_turbo_streams
@@ -111,6 +114,14 @@ def new_link
 
     private
 
+    # Show a danger toast with the action's hint (resolved relative to the
+    # controller/action), appending the service's error detail (e.g. why a
+    # non-empty section cannot be deleted) when present.
+    def render_section_error_via_turbo_stream(call)
+      message = [t(".error"), call.message].compact_blank.join(" ")
+      render_error_flash_message_via_turbo_stream(message:)
+    end
+
     def set_user_custom_field_section
       @user_custom_field_section = UserCustomFieldSection.find(params.expect(:id))
     end

config/locales/en.yml

@@ -445,6 +445,20 @@ en:
           <p>Hello,</p>
           <p>A new project has been created: projectValue:name</p>
           <p>Thank you</p>
+      project_custom_field_sections:
+        destroy:
+          error: "The section could not be deleted."
+        drop:
+          error: "The section could not be reordered."
+        move:
+          error: "The section could not be reordered."
+      user_custom_field_sections:
+        destroy:
+          error: "The section could not be deleted."
+        drop:
+          error: "The section could not be reordered."
+        move:
+          error: "The section could not be reordered."
       work_packages_identifier:
         page_header:
           description: Choose between classic numerical work package IDs or semantic project-specific ones that prepend the project identifier to the work package ID.