Fix rubocop errors

Author: dombesz

modules/backlogs/app/controllers/backlogs/work_packages_controller.rb

@@ -36,24 +36,12 @@ class WorkPackagesController < BaseController
 
     # Deferred ActionMenu items (Primer include-fragment).
     def menu
-      max_position = displayed_work_packages.maximum(:position) || 0
-
-      open_sprints_exist = Sprint.for_project(@project)
-                                 .visible
-                                 .not_completed
-                                 .where.not(id: @work_package.sprint_id)
-                                 .exists?
-
-      other_buckets_exist = BacklogBucket.where(project: @project)
-                                   .where.not(id: @work_package.backlog_bucket_id)
-                                   .exists?
-
       render(Backlogs::WorkPackageCardMenuComponent.new(
                work_package: @work_package,
                project: @project,
                max_position:,
-               open_sprints_exist:,
-               other_buckets_exist:,
+               open_sprints_exist: open_sprints_exist?,
+               other_buckets_exist: other_buckets_exist?,
                current_user:
              ),
              layout: false)
@@ -142,5 +130,20 @@ def displayed_work_packages
         @work_packages.merge(WorkPackage.backlogs_inbox_for(project: @project))
       end
     end
+
+    def max_position = displayed_work_packages.maximum(:position) || 0
+
+    def open_sprints_exist?
+      Sprint.for_project(@project).visible
+                                  .not_completed
+                                  .where.not(id: @work_package.sprint_id)
+                                  .exists?
+    end
+
+    def other_buckets_exist?
+      BacklogBucket.where(project: @project)
+                   .where.not(id: @work_package.backlog_bucket_id)
+                   .exists?
+    end
   end
 end

modules/backlogs/spec/controllers/backlogs/work_packages_controller_spec.rb

@@ -875,8 +875,8 @@
 
     context "when the work package is in a bucket" do
       let(:current_bucket) { create(:backlog_bucket, project:) }
-      let(:other_project_bucket_wp) { create(:work_package, status:, project:, backlog_bucket: current_bucket) }
-      let(:params) { { project_id: project.id, id: other_project_bucket_wp.id } }
+      let(:current_bucket_wp) { create(:work_package, status:, project:, backlog_bucket: current_bucket) }
+      let(:params) { { project_id: project.id, id: current_bucket_wp.id } }
 
       it "responds with a dialog turbo stream" do
         subject