Added check-runtime to CI#404
Draft
antkve wants to merge 10 commits into
Draft
Conversation
Co-authored-by: Karol Kokoszka <karol@parity.io>
bkontur
reviewed
Apr 13, 2026
| Proxy: pallet_proxy = 62, | ||
| } | ||
| ); | ||
| #[frame_support::runtime(legacy_ordering)] |
Collaborator
There was a problem hiding this comment.
@antkve we don't need to modify bulletin-polkadot solochain runtime, it will be remove soon
bkontur
reviewed
Apr 13, 2026
| key: try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.get-date.outputs.today }} | ||
|
|
||
|
|
||
| check-runtimes: |
Collaborator
There was a problem hiding this comment.
@antkve please, add here some specific/short desc what @polkadot-api/check-runtime@latest is really checking
bkontur
reviewed
Apr 14, 2026
| check-runtimes: | ||
| needs: [runtime-matrix] | ||
| runs-on: ubuntu-latest | ||
| if: github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' && needs.runtime-matrix.outputs.check-runtime != '[]' |
Collaborator
There was a problem hiding this comment.
@antkve can we just use that bool directly?
Suggested change
| if: github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' && needs.runtime-matrix.outputs.check-runtime != '[]' | |
| if: github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' && needs.runtime-matrix.outputs.runtime.check-runtime |
I would remove:
# Filter runtimes with check_runtime enabled (metadata hash matches the live chain)
CHECK_RUNTIME_TASKS=$(jq -c '[.[] | select(.check_runtime == true)]' scripts/runtimes-matrix.json)
echo --- check-runtime tasks ---
echo $CHECK_RUNTIME_TASKS
echo "check-runtime=$CHECK_RUNTIME_TASKS" >> $GITHUB_OUTPUT
Contributor
Author
There was a problem hiding this comment.
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Collaborator
|
@antkve can you please rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.