fix(ui): classify attack path findings exactly#11244
Open
Alan-TheGentleman wants to merge 1 commit into
Open
Conversation
- Treat only ProwlerFinding as a clickable finding node - Keep GuardDuty and Inspector findings as graph resources - Add regression coverage for provider finding resources
Contributor
|
Please add an entry to the corresponding |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
2 package(s) affected
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Attack Paths graph nodes whose provider resource labels include
Finding(for exampleGuardDutyFindingandAWSInspectorFinding) were being treated as clickable Prowler findings. Those nodes are graph resources, not Prowler findings with drawer details, so clicking them could try to open missing finding information.Description
This PR tightens Attack Paths finding-node detection to classify only
ProwlerFindingas a clickable finding node.ProwlerFindinglabel classifier.No new dependencies are required.
Steps to review
GuardDutyFindingorAWSInspectorFindingresource nodes.ProwlerFindingnodes remain clickable and open the finding drawer.GuardDutyFindingandAWSInspectorFindingnodes behave as normal resources and do not show/open the Prowler finding drawer.cd ui && pnpm test:unit app/(prowler)/attack-paths/(workflow)/query-builder/_lib/layout.test.ts app/(prowler)/attack-paths/(workflow)/query-builder/_lib/node-visuals.test.ts app/(prowler)/attack-paths/(workflow)/query-builder/_lib/graph-colors.test.ts app/(prowler)/attack-paths/(workflow)/query-builder/_lib/graph-utils.test.ts app/(prowler)/attack-paths/(workflow)/query-builder/_lib/export.test.ts app/(prowler)/attack-paths/(workflow)/query-builder/_components/graph/graph-legend.test.tsx app/(prowler)/attack-paths/(workflow)/query-builder/_components/node-detail/node-detail-panel.test.tsx app/(prowler)/attack-paths/(workflow)/query-builder/attack-paths-page.test.tsxChecklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.