Skip to content

Security Check: False positive on PASSWORD parameter in processing algorithms #368

Description

@signedav

Summary

A parameter called PASSWORD is nothing unusual on algorithms.

class Ili2dbAlgorithm(QgsProcessingAlgorithm):
    SERVICE = "SERVICE"
    HOST = "HOST"
    DBNAME = "DBNAME"
    PORT = "PORT"
    USER = "USER"
    PASSWORD = "PASSWORD"
    SCHEMA = "SCHEMA"
    SSLMODE = "SSLMODE"
    USESUPERUSER = "USESUPERUSER"
    AUTHCFG = "AUTHCFG"
    def __init__(self):
        super().__init__() 

There are even QGIS core algorithms using it https://github.com/qgis/QGIS/blob/master/python/plugins/processing/algs/gdal/OgrToPostGis.py#L69

No biggy, I can deactivate the check with # pragma: allowlist secret but maybe this is something we might can ignore generally (no idea about the implementation).

If this issue is not appropriate or irrelevant, then feel free to close again ✌️

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugPATCH bump (vX.Y.Z) · Fixed · bug fix

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions